test: add test cases for main

[OmkarSarkar204]

Fixes: #1352

Tests addded for __main__.py:

• register_plugins
• validate_plugin_registry
• display_first_use_documentation
• connect_to_fc_and_set_vehicle_type
• resolve_writable_vehicle_dir_for_initial_download
• initialize_filesystem
• vehicle_directory_selection
• component_editor
• process_component_editor_results
• backup_fc_parameters
• parameter_editor_and_uploader

[OmkarSarkar204]

Im planning to add a few more tests, will remove it from draft when ready.

[coveralls]

Pull Request Test Coverage Report for Build 23251116424

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 93.188%

---

Totals
Change from base Build 23238548626:	0.1%
Covered Lines:	10944
Relevant Lines:	11744

---

💛 - Coveralls

[OmkarSarkar204]

Hello @amilcarlucas , can you please take a look at this and check if its ok?

[amilcarlucas]

Thanks. Looks good at first sight. I rebased it to re-trigger the tests.

[Copilot]

Pull request overview

Adds unit tests covering key control-flow branches in ardupilot_methodic_configurator.__main__ to address #1352 and improve confidence in startup orchestration, plugin validation, filesystem setup, editor flows, backups, and parameter upload behavior.

Changes:

• Added targeted tests for plugin registration/validation and first-use documentation URL behavior
• Added tests for connection error handling, writable-dir fallback, and filesystem initialization fatal-paths
• Added tests for component/parameter editor paths, backups, GPS param rename behavior, and main() orchestration

[Copilot]

mock_warn.call_args[0][1] assumes logging_warning is called with at least two positional args and that the second is a dict. If logging_warning uses keyword args (common for structured logging) or only one positional arg, this will raise (IndexError/TypeError) and make the test incorrectly fail. Prefer asserting against mock_warn.call_args.kwargs (or mock_warn.call_args[1]) and only fall back to positional arg inspection if the production signature truly passes a dict positionally.

Suggested change

	warn_kwargs: dict = mock_warn.call_args[0][1]
	args, kwargs = mock_warn.call_args
	if kwargs:
	warn_kwargs: dict = kwargs
	elif len(args) > 1 and isinstance(args[1], dict):
	warn_kwargs = args[1]
	else:
	pytest.fail("logging_warning was not called with expected keyword or dict positional arguments")

[Copilot]

Patching ProgramSettings.get_setting with a blanket return_value=False makes the test brittle and can accidentally push main() down unintended branches if main() (now or later) reads a non-boolean setting (e.g., string-valued settings like GUI mode). Using a side_effect that returns specific values per key (or patching only the specific settings read in this test) will keep the test focused and reduce false failures when main() evolves.

[Copilot]

This assertion only verifies that an error was logged, but not that it identifies the missing plugin. To make the test protect the diagnostic behavior (and prevent regressions where the wrong plugin name is reported), assert that the logged call includes "unknown_plugin" (either in args or kwargs, depending on logging_error's signature).

Suggested change

	mock_err.assert_called_once()
	mock_err.assert_called_once()
	args, kwargs = mock_err.call_args
	# Ensure that the logged error message identifies the missing plugin
	combined = " ".join([str(a) for a in args] + [str(v) for v in kwargs.values()])
	assert "unknown_plugin" in combined

[OmkarSarkar204]

Fixed the pylint error , should be passing now :)

[amilcarlucas]

Thanks for the tests, and the pylint fix. merged