Update the recent project history when opening projects

[amilcarlucas]

No description provided.

[Copilot]

Pull request overview

Updates project-opening behavior so that opening a vehicle directory also records it in the “recently used” history (handled by the business layer rather than the UI).

Changes:

• Persist “recently used vehicle directory” history when VehicleProjectManager.open_* succeeds.
• Expand data-model tests to assert history is recorded on success and not recorded on failure.
• Add frontend tests intended to ensure the view doesn’t write recent-history directly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tests/test_frontend_tkinter_project_opener.py	Adds UI-layer tests asserting history isn’t updated directly by the view.
tests/test_data_model_vehicle_project.py	Updates manager tests to expect history updates on successful opens and no updates on failures.
ardupilot_methodic_configurator/data_model_vehicle_project.py	Implements history recording inside open_vehicle_directory / open_last_vehicle_directory.

[Copilot]

manager.open_vehicle_directory(...) now calls store_recently_used_vehicle_dir(...) internally, which (by default) delegates to LocalFilesystem.store_recently_used_vehicle_dir(...). If this test doesn’t patch/stub that history-writing path in its setup, it may introduce real filesystem/config side effects and become flaky. Patch manager.store_recently_used_vehicle_dir (or LocalFilesystem.store_recently_used_vehicle_dir) in this workflow test and assert it was called with vehicle_path.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
11500	10473	91%	89%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
ardupilot_methodic_configurator/backend_filesystem_program_settings.py	97%	🟢
ardupilot_methodic_configurator/data_model_vehicle_project.py	97%	🟢
ardupilot_methodic_configurator/data_model_vehicle_project_creator.py	100%	🟢
ardupilot_methodic_configurator/data_model_vehicle_project_opener.py	96%	🟢
TOTAL	98%	🟢

updated for commit: 5339f33 by action🐍

[github-actions]

Test Results

    2 files  ±0      2 suites  ±0   28m 15s ⏱️ -15s
3 017 tests +3  3 012 ✅ +3   5 💤 ±0  0 ❌ ±0 
6 034 runs  +6  6 024 ✅ +6  10 💤 ±0  0 ❌ ±0 

Results for commit 5339f33. ± Comparison against base commit e991dd6.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.

tests.test_data_model_vehicle_project_creator.TestVehicleProjectCreationWorkflow ‑ test_recently_used_directories_are_stored_after_successful_creation
tests.test_data_model_vehicle_project_opener.TestVehicleDirectoryOpening ‑ test_recently_used_directory_is_stored_after_successful_opening

tests.test_data_model_vehicle_project.TestDirectoryAndPathOperations ‑ test_creation_does_not_store_vehicle_dir_in_history
tests.test_data_model_vehicle_project.TestDirectoryAndPathOperations ‑ test_creation_updates_recent_history
tests.test_data_model_vehicle_project_creator.TestVehicleProjectCreationWorkflow ‑ test_creator_does_not_store_history_itself
tests.test_frontend_tkinter_project_opener.TestVehicleProjectOpenerWindow ‑ test_view_does_not_update_history_directly_when_opening_last
tests.test_frontend_tkinter_project_opener.TestVehicleProjectOpenerWindow ‑ test_view_does_not_update_history_directly_when_opening_manual

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Missing punctuation between 'history' and 'the manager'. Add a semicolon, period, or em dash for clarity.

Suggested change

	the window should not update the history the manager is responsible for that.
	the window should not update the history; the manager is responsible for that.