wscript: Cleanup around 'ardour' + MAJOR #907
Open
kiilerix wants to merge 5 commits intoArdour:masterfrom
Open
wscript: Cleanup around 'ardour' + MAJOR #907kiilerix wants to merge 5 commits intoArdour:masterfrom
kiilerix wants to merge 5 commits intoArdour:masterfrom
Conversation
Keep it tidy.
…NAL_NAME The build system does a lot all over to keep ardour8 (almost) without file name conflicts if installed next to ardour9. Often by appending MAJOR in lots of places. lwrcase_dirname was just 'ardour' + MAJOR. The naming of lwrcase_dirname did not say much about what it was, and it was only defined locally in build(). We set INTERNAL_NAME globally in configure(), exactly like MAJOR is set. INTERNAL_NAME is similar to the existing PROGRAM_NAME, which contains the visible name. INTERNAL_NAME is however more intended to be used for namespacing installed files. We will soon use it in a lot of places where MAJOR used to be used. The end goal is to make sure there only is one place where the "ardour"+major naming policy is hardcoded. And to make it configurable instead of hardcoded. Things should not be repeated so they are hard to change, and they should not be hardcoded. The policy of including the major version in the internal name is not necessarily relevant when always using latest version. Most programs don't do that. But also, if there for some reason should be a need to install several minor versions side by side, then it would be relevant to include both the major and the minor number.
Replace repeated hardcoded appending of MAJOR with reuse of the existing computed name, which is as available in env, exactly as MAJOR was. Note: INTERNAL_NAME will sometimes be used with a prefix like 'gtk2_' or 'lib', or a suffix like '-lua'.
Replace a redundant custom computation with the existing computed name.
… and appending MAJOR
kiilerix
changed the title
sdevisch
approved these changes
Feb 11, 2026
sdevisch
approved these changes
Feb 11, 2026
sdevisch
previously approved these changes
Feb 11, 2026
x42
dismissed
sdevisch’s stale review
The user has no relationship with the project, and batch approved all PR. Troll/Spam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.