Conversation
spoonincode
reviewed
May 16, 2025
include/eosio/vm/backend.hpp
Outdated
| std::forward<F>(f)(); | ||
|
|
||
| using return_type = std::invoke_result_t<F>; | ||
| if constexpr (std::is_void_v<return_type>) { |
Contributor
There was a problem hiding this comment.
I'm suspicious this check isn't actually required.
Contributor
There was a problem hiding this comment.
yeah I tried and replacing all this with just return std::forward<F>(f)(); compiled okay (on spring's return_status branch)
Contributor
Author
There was a problem hiding this comment.
Thanks! You are correct. It is now even cleaner.
heifner
approved these changes
May 16, 2025
spoonincode
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
timed_run()is used in Spring for executingapply()andsync_call()entry points.apply()is avoidwhilesync_call()returnsint64_t.With C++ template function traits, it is elegant to make a single
timed_run()for both void and non-void return types.Resolves #41
API Changes
Documentation Additions