Skip to content

fix: Add support for rollup 3 - #225

Open
mathiasschopmans wants to merge 1 commit into
Anidetrix:mainfrom
mathiasschopmans:patch-1
Open

fix: Add support for rollup 3#225
mathiasschopmans wants to merge 1 commit into
Anidetrix:mainfrom
mathiasschopmans:patch-1

Conversation

@mathiasschopmans

Copy link
Copy Markdown

Fixes #224

@mathiasschopmans mathiasschopmans changed the title Add support for rollup 3 fix: Add support for rollup 3 Nov 3, 2022
@hanorine

hanorine commented Feb 6, 2023

Copy link
Copy Markdown

Would love to get this support merged in as soon as possible. Thanks.

@mryechkin

Copy link
Copy Markdown

@Anidetrix any chance of this getting looked at? My team has just recently updated to Rollup v3 and are looking to start using this plugin, but are blocked due to the v2 limitation.

Locally I can still install with -f flag, but that won't work for deployment pipelines.

Thank you

@drzraf

drzraf commented Jun 1, 2023

Copy link
Copy Markdown

Quoting https://github.com/Anidetrix/rollup-plugin-styles#why

Because alternatives did not look good enough - they are either too basic, too buggy or poorly maintained.

:|

@mryechkin

Copy link
Copy Markdown

FYI - I've moved on to using the @ironkinoko/rollup-plugin-styles package, which looks to be a v3 compatible fork.

@hanorine

Copy link
Copy Markdown

FYI - I've moved on to using the @ironkinoko/rollup-plugin-styles package, which looks to be a v3 compatible fork.

That worked for me. I hope his changes will be merged into here.

@julianjelfs

Copy link
Copy Markdown

Also - add support for rollup 4 馃槀 - please please

@megheaiulian

Copy link
Copy Markdown

I have created a fork at https://github.com/plumelo/rollup-styles rollup-styles that supports rollup v3 and v4.

@RoryDuncan

Copy link
Copy Markdown

I have created a fork at https://github.com/plumelo/rollup-styles rollup-styles that supports rollup v3 and v4.

For your potential future packages, @megheaiulian鈥攔ollup plugins are supposed to follow the naming convention "rollup-plugin-<package>". Bit late now鈥攋ust letting you know the convention exists.

@megheaiulian

megheaiulian commented Nov 22, 2023

Copy link
Copy Markdown

@RoryDuncan I am aware of that convention but i couldn't find any good and meaningful unprefixed npm package name.
If you have a good suggestion I'd welcome it. The package can be renamed while having previous names and versions still working ...

Renamed the fork to rollup-plugin-styler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for rollup v3

7 participants