Use window manager from OS for control dialog#1302
Conversation
gentlegiantJGC
left a comment
gentlegiantJGC
left a comment
There was a problem hiding this comment.
I like this suggestion.
It can be more simpliy implemented by modifying the SimpleDialog class to take a style argument.
The dialog is being shown modally so is minimise useful?
What does SYSTEM_MENU do?
|
I found that as I added more hotkeys I always wanted to maximize the keyboard controls mapping window. Since there were no OS controls that was not possible (or I didn't know how). |
| | wx.CLOSE_BOX | ||
| | wx.MAXIMIZE_BOX | ||
| | wx.MINIMIZE_BOX | ||
| | wx.SYSTEM_MENU |
There was a problem hiding this comment.
Im not sure why SYSTEM_MENU is here. maybe leftover from some experimental code? Guess I should remove it....
There was a problem hiding this comment.
oh. i wonder if it's related to the window manager putting the system menu in the top left corner on windows. it's the Icon that has close and other stuff in it.
There was a problem hiding this comment.
i dont see a reason to remove the minimize. if people dont use it it's not in the way. I changed to the style argument.
There was a problem hiding this comment.
This is only ever shown modally.
If the window is minimised the user cannot interact with the rest of the program and it is confusing to the user how to get back to the program. I would prefer if minimising was disabled.
Perhaps the style argument could be moved into the KeyConfigDialog constructor so that the caller can choose the options.
There was a problem hiding this comment.
oh right. minimize could be a problem. removed.
|
I am still confused what SYSTEM_MENU does. |
|
Perhaps it isn't used. It seems to be part of the default style so I have no issue leaving it. |
|
Looks good other than the formatting change. |
2 participants
The controls dialog does not have standard OS buttons for the window. Maximizing and Closing are manual operations and not fast like other applications. (yes closing is available with the buttons on the bottom but not fast). Escape doesn't do anything like a regular dialog so let's treat this as a real window.
This patch allows the OS to control the window and add standard buttons. Only tested on Windows so far.