fix(ci): replace inherited Codecov literal with OIDC - #7
Conversation
|
Exact head Cursor (@cursor) review bugbot run copilot-pull-request-reviewer review @copilot review Please report every substantive correctness, security, CI, and maintainability issue; report exact zero if none. |
|
Addressed the coverage-order finding at exact head Cursor (@cursor) review bugbot run copilot-pull-request-reviewer review @copilot review Please re-review the complete exact-head diff and report every issue; report exact zero if none. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9de63a0. Configure here.
|
All exact-head CI and the fork canary are now green. Both review threads are resolved: the first was fixed in Cursor (@cursor) review bugbot run Please perform a final exact-head review and report zero if no actionable issue remains. |
|
Exact head Cursor (@cursor) review bugbot run copilot-pull-request-reviewer review @copilot review Please review the entire exact-head diff and report every issue; report exact zero if none. |

Summary
envliterals recursively with sanitized diagnosticsSecurity boundary
Coverage generation runs with
contents: readonly. Coverage crosses a one-day artifact boundary into exact no-checkout upload jobs. Only the trusted upload job can request an OIDC token; fork and Dependabot jobs cannot.The inherited value matches upstream and is not an Ambiguous-Interactive repository or organization secret, per the repository owner. This PR does not reproduce it.
Validation
References Ambiguous-Interactive/ambiguous-organization-build-lock#45
Note
Medium Risk
Changes CI auth boundaries and coverage upload paths; mistakes could break uploads or widen token exposure, but scope is limited to GitHub Actions and adds contract tests.
Overview
Removes the hardcoded Codecov token from
integrity-checkand stops using the curl-based uploader in the test job. Coverage is uploaded only after it crosses a short-lived artifact from acontents: readtest job into separate, no-checkout upload jobs.Trusted main and same-repo PR runs use pinned Codecov v7 with OIDC (
id-token: writeonly on that job). Fork and Dependabot PRs upload tokenless withoverride_branchand no OIDC.Adds
workflow-credential-policy(scanner + tests) and wiresyarn test:workflow-policyinto CI.verify-resource-cleanup-contractgains RC018 (recursive ban on credential-shapedenvliterals with safe diagnostics) and RC019 (locks the artifact/OIDC/tokenless job split and ordering).Reviewed by Cursor Bugbot for commit e6b2df8. Bugbot is set up for automated code reviews on this repo. Configure here.