Make string demo handlers opt in - #580
Merged
Eli Pinkerton (wallstop) merged 11 commits intoSep 11, 2026
Merged
Conversation
7 tasks
Contributor
Performance NumbersMeasured commit: Benchmark methodology and execution profile are unchanged; the historical Standalone comparison is diagnostic regression smoke. Historical Standalone deltaDelta direction: + is better; - is worse.
Current TargetMap evidenceThese raw rows are current-run diagnostics. Use fresh bracketed controls before accepting a micro-optimization. |
20 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 814bb7f. Configure here.
Eli Pinkerton (wallstop)
deleted the
codex/retain-foundation-evidence
branch
September 11, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Every
MessageAwareComponentregistered three demo string handlers by default. Ordinary components retained registrations they did not request.The setup guide implied that
MessagingComponentwas required. The diagnostics tour did not expose common failure and visibility states, and CI did not consume the package artifacts it exported.What changed
RegisterForStringMessages.How we know
validate:all, formatting, spelling, package, analyzer, and workflow-policy checks pass locally.cb8e6406.Related work
Refs #502.
Refs #506.
Refs #507.
Refs #508.
Closes #573.
Issue #502 remains open. Issue #573 is complete and closed with its GREEN/keep evidence recorded.
Note
High Risk
Breaking default behavior for every
MessageAwareComponentsubclass that relied on implicit string demos without an explicit opt-in; CI and export paths add substantial new validation surface.Overview
Breaking (4.0):
MessageAwareComponentno longer registers built-in string demo handlers unless subclasses overrideRegisterForStringMessages => true. Docs, README, and DXMSG006 messaging now describe inherited/parent registrations instead of “default string handlers.”The Upgrade 3.x Fast Handlers to 4.0 editor tool still converts
ref→inand, when it updates inherited string-handler overrides, can insertRegisterForStringMessages => true(with manual-review paths for partial types and existing opt-outs).The Diagnostics Tooling Exerciser guided tour adds steps for disabled receivers, released tokens, destroyed components, and emissions on a separate
MessageBus/standalone token so global Message Monitor/Flow Graph boundaries are explicit.CI:
workflow_dispatchgains optionalconsumer_install_validation(mutually exclusive withshipping_fidelity). That path runsexport-unitypackage.ps1with-VerifyConsumerInstalls, installing the exact Git SHA, UPM tarball, and classic.unitypackagein clean projects, importing all four samples, and running the eight existing sample contract tests. Builtin module manifest dropscom.unity.modules.vrfor matrix compatibility.Tests, snippet-compilation regex, and perf-evidence runbook entries are updated to match.
Reviewed by Cursor Bugbot for commit cb8e640.