-
Notifications
You must be signed in to change notification settings - Fork 87
feat: Add edit and delete buttons for published code lists in the layout editor #17631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: add-published-code-lsits-to-editor
Are you sure you want to change the base?
feat: Add edit and delete buttons for published code lists in the layout editor #17631
Conversation
📝 WalkthroughWalkthroughThe changes refactor the published code list editing functionality by extracting a dedicated Changes
Poem
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| readonly referenceString: string; | ||
| }; | ||
|
|
||
| function PublishedCodeListEditor({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to a separate file since the component has become more complex.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## add-published-code-lsits-to-editor #17631 +/- ##
===================================================================
Coverage 96.00% 96.00%
===================================================================
Files 2437 2439 +2
Lines 30928 30946 +18
Branches 3606 3606
===================================================================
+ Hits 29692 29710 +18
Misses 921 921
Partials 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| [DEFAULT_LANGUAGE]: textResourcesMock.resources, | ||
| }; | ||
| const onEditButtonClick = jest.fn(); | ||
| const onEditInternalButtonClick = jest.fn(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed this since it specifically refers to the edit button on the editor for internally defined option lists.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Important
This pull request is stacked upon #17588, which should be merged first.
Description
This pull requests adds edit and delete buttons to the published code list interface in the layout editor. The video below demonstrates what happens when the user clicks on them.
Spiller.inn.2026-02-03.142853.mp4
I have added the
skip-second-approvallabel since this is behind a feature flag and it will be better to test when all of #17339 is complete.Verification
Summary by CodeRabbit
Release Notes
New Features
Refactor