Skip to content

Conversation

@subkanthi
Copy link
Collaborator

Updated docker compose to set clickhouse server/spark session timezone.

@subkanthi subkanthi requested a review from xieandrew January 15, 2026 20:07
Copy link

@xieandrew xieandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question

spark.eventLog.dir /home/iceberg/spark-events
spark.history.fs.logDirectory /home/iceberg/spark-events
spark.sql.catalogImplementation in-memory
# spark.sql.session.timeZone America/Chicago

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the example added here instead of under services.spark-iceberg.configs, which is where the README says to add it? I know both will work but wondering for consistency if they should be in the same place.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated README, please check

@subkanthi subkanthi requested a review from xieandrew January 16, 2026 16:29
Copy link

@xieandrew xieandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@subkanthi subkanthi merged commit d2d7233 into master Jan 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants