Show users reactions, popup system by Rastub · Pull Request #1641 · Alt-Org/Altzone

Rastub · 2026-06-23T10:59:23Z

Here's the popup system for the chat to see who's had send what reaction, it still doesn't have users avatars yet (so it will use messages avatar in place)

And fixed the reaction selection to work properly

Looks smt like this:

sorry it took long, getting the right data was pain

added a scroll bar to popup reactionfield so that it wont go over the tab (still haven't gotten reactionfield buttons work at ShowUserPopUp on the popup, it sorta works but it only updates the messagebox reactionfield)

system now updates correct reactions

- LineOrder place changed so that it wont increase when there isnt new reaction added - Forgot to add " if(Popup.gameObject.activeSelf)" for 288

Reactions are now updated on Reaction PopUp

- Changed all ChatShowUsersPopUpData variable's into private - fixed an issue where reaction selection did not update properly

- Fixed an issue where other user adding reaction from a other message wont update the popup - Fixed an issue where reaction selection gets updated when other user is adding their own reaction

- System now updates the ReactionData both main player and other users reactions data (removing system for it, isn't here yet)

- ReactionData now removes correct user ID in toggle system (right now the system only works to main user directly not other users yet)

- System now updates the info even if its main player or other players I finally got the thing work after so long of grinding the code

- Cleared some code and did some adjustment to some parts

- fixed the reaction content sizing for other devices - some code cleaning

BillTheBeast · 2026-06-29T11:33:34Z

        ClosePopup();
    }


-    public void reactiontext()
+    private void reactiontext()


Metodin nimi pitäisi alkaa isolla.

BillTheBeast · 2026-06-29T11:49:38Z

@@ -103,7 +100,7 @@ public void reactiontext()

        }

-        ReactionAmounText.text = $"{activeChildren} reaktiota";
+        _reactionAmounText.text = $"{activeChildren} reaktiota";


Korvaa tämä TextLanguageSelectorCaller skriptin metodilla. (Eli lisää tähän teksti objektiin tuo skripti ja sit voit pistää tuon tekstin sen sisään ja vain lähettää tuon muuttuvan arvot sille.)

BillTheBeast · 2026-06-29T11:55:47Z

                _userInfo = _userInfo.OrderBy(m => m._order).ToList();
-                _OrderButtonText.text = "Old";
+                _orderButtonText.text = "Old";


Kannattaa varmaankin lisätä tarkistus siitä että mikä kieli on käytössä ja jos kyseessä on suomi niin sit, tässä lukee Uusi.

Sama tuohon seuraavaan vaihtoehtoon.

BillTheBeast · 2026-06-29T12:02:00Z

-                addedReaction.ResetReactions();
-
+
+            AddReaction(reaction, (Mood)Enum.Parse(typeof(Mood), reaction.emoji), messageid, _reactionPaneldata._reactionField, message);


_reactionPaneldata._reactionField on ilmiselvästi virheellisesti nimetty, koska alaviiva nimen edessä tarkoittaa yksityistä globaalia muuttujaa, mutta tuo reactionField on selvästikin julkinen jolloin siinä ei pitäisi olla alaviivaa ja ekan kirjaimen pitäisi olla isolla.

BillTheBeast · 2026-06-29T12:04:37Z

                            }
                    }));
-
-                        _selectedMessage.SetMessageInactive();
+                    GenarateReactionObjects(_reactionPaneldata._reactionsContent);


Sama huomautus kuin aikaisemmin nimeämis asioista..

BillTheBeast · 2026-06-29T12:06:10Z

    }
-
    /// <summary>
    /// Adds the chosen reaction to the selected message.
    /// </summary>
    public void AddReaction(ServerReactions _reaction, Mood mood, string message_id, GameObject ReactionPanel = null, ChatMessage message = null)


Poista alaviiva _reaction muuttujan nimestä.

BillTheBeast · 2026-06-29T12:09:05Z

@@ -312,145 +284,133 @@ public void AddReaction(ServerReactions _reaction, Mood mood, string message_id,
    /// Toggles the added reactions as selected and unselected.
    /// </summary>
    /// <param name="reactionHandler"></param>
-    public void ToggleReaction(ChatReactionHandler reactionHandler, ChatMessage message, ServerReactions _reaction)
+    public void ToggleReaction(ChatReactionHandler reactionHandler, ServerReactions _reaction, ChatMessage message)


"message" attribuuttia ei käytetä, joten sen varmaankin voisi poistaa.

BillTheBeast · 2026-06-29T12:10:12Z

        }
    }

-    private void ShowUsers(ChatMessage message)
+    private void ShowUsers(ChatReactionHandler reactionHandler, ChatMessage message)


Tätä reactionHandleriä ei käytetä, joten se voidaan tod.näk. poistaa tästä.

BillTheBeast · 2026-06-29T12:19:38Z

+
+        _longClick = true;
+
+        Invoke("ResetLongClick", 2);


Yleensä suosittelen olemaan käyttämästä suoria string nimiä kun metodeja kutsutaan, koska jos sen metodinnimi muuttuu syystä tai toisesta tämä ei päivity oikein ja ei edes huomauta että ei toimi ennen kuin yrität käyttää sitä. Vaihtamalla tähän nameof operaattorin tämä korjaantuu, sillä nyt koodi osaa seurata sitä metodin varsinaista nimeä ja kertoa jos jokin on pielessä.

BillTheBeast · 2026-06-29T12:21:26Z

    }

    private void ResetLongClick()
    {
        _longClick = false;
    }

-    private void RemoveReaction(ChatReactionHandler reaction)
+    private void RemoveReaction(ChatReactionHandler reaction, ChatMessage message)


"message" attribuuttia ei käytetä, voi mahdollisesti poistaa.

BillTheBeast · 2026-06-29T12:24:36Z

        //Checks if the set gameObject is on or not
-            HorizontalLayoutGroup reactionsField = _reactionPaneldata._reactionField.GetComponent<HorizontalLayoutGroup>();
+        HorizontalLayoutGroup reactionsField = _reactionPaneldata._reactionField.GetComponent<HorizontalLayoutGroup>();
+        reaction.transform.SetParent(null);


Tarvitseeko tätä edes siirtää eri parentin alle, jos se tuhotaan tähän perään samantien.

BillTheBeast · 2026-06-29T12:27:30Z


+        GenarateReactionObjects(_reactionPaneldata._reactionsContent);


Tarvitseeko tätä edes kutsua jos ainoa mitä tämän metodin pitäisi tehdä on poistaa tuo reaktio, mikä tuossa ylempänä jo tehtiin.

BillTheBeast · 2026-06-29T12:29:27Z


-        StartCoroutine(GetPlayerData(player =>
+    //Clearns the list empty (with those what has players ID) so that new data can be added
+    private void ClearList(ServerReactions _reaction)


Tämä metodihan ei varsinaisesti tyhjennä mitään vaan poistaa reaktion valinnan. Kannattaisiko uudelleennimetä?

BillTheBeast · 2026-06-29T12:35:03Z

@@ -159,6 +159,9 @@ public void ReactionChatCall(ServerReactions EmojiId, ChatMessage message)
        //Gets the set data we need to get to import saved reactions
        MessageReactionsHandler ChildsScript = ReactionObject.GetComponent<MessageReactionsHandler>();
        ChildsScript.AddReaction(EmojiId, (Mood)Enum.Parse(typeof(Mood), EmojiId.emoji), _id, ReactionsPanel, message);
+
+        //Used for ChatShowUsersPopUpData
+        ChildsScript._reactionData.Add(EmojiId);


Eikös tämän pitäisi olla tuon AddReaction metodin sisällä eikä tässä? Tällöin tuon ReaktioDatan voi myös pistää yksityiseksi.

BillTheBeast

Noiden huomioiden lisäksi popupin sisältä ei tällä hetkellä voi poistaa valittua reaktiota ainoastaan lisätä uusi tai vaihtaa olemassa oleva. Tuo kannattaa korjata.

- Added Language system to the popup - more code cleaning

Rastub added 10 commits June 1, 2026 15:22

ShowUserPopUp 1.0

040d76e

added a scroll bar to popup reactionfield so that it wont go over the tab (still haven't gotten reactionfield buttons work at ShowUserPopUp on the popup, it sorta works but it only updates the messagebox reactionfield)

ShowUserPopUp 1.1

d51ba5f

system now updates correct reactions

ShowUserPopUp 1.2

b71610c

- LineOrder place changed so that it wont increase when there isnt new reaction added - Forgot to add " if(Popup.gameObject.activeSelf)" for 288

ShowUserPopUp 1.3

408e9cc

Reactions are now updated on Reaction PopUp

ShowUserPopUp 1.4

b679952

- Changed all ChatShowUsersPopUpData variable's into private - fixed an issue where reaction selection did not update properly

ShowUserPopUp 1.5

528d27f

- Fixed an issue where other user adding reaction from a other message wont update the popup - Fixed an issue where reaction selection gets updated when other user is adding their own reaction

ShowUserPopUp 1.6

0736881

- System now updates the ReactionData both main player and other users reactions data (removing system for it, isn't here yet)

ShowUserPopUp 1.7

b69c458

- ReactionData now removes correct user ID in toggle system (right now the system only works to main user directly not other users yet)

ShowUserPopUp 1.8

1a76707

- System now updates the info even if its main player or other players I finally got the thing work after so long of grinding the code

ShowUserPopUp 2.0

cd43142

- Cleared some code and did some adjustment to some parts

Rastub requested a review from BillTheBeast June 23, 2026 11:00

ShowUserPopUp 2.1

ac3ed27

- fixed the reaction content sizing for other devices - some code cleaning

BillTheBeast reviewed Jun 29, 2026

View reviewed changes

BillTheBeast requested changes Jun 29, 2026

View reviewed changes

ShowUserPopUp 2.1

46ee3ff

- Added Language system to the popup - more code cleaning

		addedReaction.ResetReactions();


		AddReaction(reaction, (Mood)Enum.Parse(typeof(Mood), reaction.emoji), messageid, _reactionPaneldata._reactionField, message);


		GenarateReactionObjects(_reactionPaneldata._reactionsContent);

Uh oh!

Conversation

Rastub commented Jun 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillTheBeast left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants