fix(webui): align home page scale#819
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (1)src_assets/**/*.{vue,js,html}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (2)
Summary by CodeRabbit
WalkthroughChanges网页视觉刷新
控制面板子模块更新
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7b86fd0 to
4f50d8b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src_assets/common/assets/web/styles/var.css (1)
24-32: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value建议为特定字体名称添加引号以解决静态分析警告。
Stylelint 提示了
value-keyword-case错误，因为Inter、BlinkMacSystemFont、Menlo、Monaco和Consolas等未加引号的特定字体名称被其规则识别为了不规范的关键字格式。虽然在 CSS 中这些未加引号的用法也是有效的，但前端的最佳实践建议为非通用（non-generic）的特定字体系列名称添加引号，这样不仅可以消除规范检查工具的误报，还能确保更严谨的浏览器解析兼容性。💡 建议的修复
- --font-family-sans: Inter, 'Segoe UI Variable Text', 'Segoe UI Variable', -apple-system, - BlinkMacSystemFont, 'Segoe UI', 'PingFang SC', 'Hiragino Sans GB', 'Noto Sans CJK SC', + --font-family-sans: 'Inter', 'Segoe UI Variable Text', 'Segoe UI Variable', -apple-system, + 'BlinkMacSystemFont', 'Segoe UI', 'PingFang SC', 'Hiragino Sans GB', 'Noto Sans CJK SC', 'Noto Sans SC', 'Noto Sans', 'Microsoft YaHei UI', 'Microsoft YaHei', sans-serif; --font-family-base: var(--font-family-sans); - --font-family-mono: ui-monospace, 'Cascadia Code', 'SFMono-Regular', Menlo, Monaco, Consolas, + --font-family-mono: ui-monospace, 'Cascadia Code', 'SFMono-Regular', 'Menlo', 'Monaco', 'Consolas', 'Liberation Mono', monospace;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src_assets/common/assets/web/styles/var.css` around lines 24 - 32, 在 `--font-family-sans` 和 `--font-family-mono` 中为所有非通用字体系列名称添加引号，尤其是 `Inter`、`BlinkMacSystemFont`、`Menlo`、`Monaco` 和 `Consolas`，以通过 `value-keyword-case` 检查；保留 `-apple-system`、`ui-monospace` 和 `sans-serif` 等系统关键字及现有字体顺序不变。Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src_assets/common/assets/web/styles/var.css`:
- Around line 24-32: 在 `--font-family-sans` 和 `--font-family-mono`
中为所有非通用字体系列名称添加引号，尤其是 `Inter`、`BlinkMacSystemFont`、`Menlo`、`Monaco` 和
`Consolas`，以通过 `value-keyword-case` 检查；保留 `-apple-system`、`ui-monospace` 和
`sans-serif` 等系统关键字及现有字体顺序不变。
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4cb9ce91-4c54-4e6e-9b6d-844e74cf43e6
📒 Files selected for processing (11)
src_assets/common/assets/web/components/common/ResourceCard.vuesrc_assets/common/assets/web/components/common/ResourceLink.vuesrc_assets/common/assets/web/public/assets/locale/en.jsonsrc_assets/common/assets/web/public/assets/locale/zh.jsonsrc_assets/common/assets/web/styles/var.csssrc_assets/common/assets/web/styles/welcome.lesssrc_assets/common/assets/web/views/Apps.vuesrc_assets/common/assets/web/views/Config.vuesrc_assets/common/assets/web/views/Home.vuesrc_assets/common/assets/web/views/Pin.vuesrc_assets/common/sunshine-control-panel
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: Windows
🧰 Additional context used
📓 Path-based instructions (1)
src_assets/**/*.{vue,js,html}
⚙️ CodeRabbit configuration file
src_assets/**/*.{vue,js,html}: 基于 Vue.js 的 Web 配置面板。审查 XSS/CSRF 安全性、 组件设计、状态管理和可访问性。
Files:
src_assets/common/assets/web/views/Apps.vuesrc_assets/common/assets/web/views/Pin.vuesrc_assets/common/assets/web/views/Config.vuesrc_assets/common/assets/web/components/common/ResourceLink.vuesrc_assets/common/assets/web/components/common/ResourceCard.vuesrc_assets/common/assets/web/views/Home.vue
🪛 Stylelint (17.14.0)
src_assets/common/assets/web/styles/var.css
[error] 25-25: Expected "Inter" to be "inter" (value-keyword-case)
(value-keyword-case)
[error] 26-26: Expected "BlinkMacSystemFont" to be "blinkmacsystemfont" (value-keyword-case)
(value-keyword-case)
[error] 29-29: Expected "Menlo" to be "menlo" (value-keyword-case)
(value-keyword-case)
[error] 29-29: Expected "Monaco" to be "monaco" (value-keyword-case)
(value-keyword-case)
[error] 29-29: Expected "Consolas" to be "consolas" (value-keyword-case)
(value-keyword-case)
🔇 Additional comments (10)
src_assets/common/sunshine-control-panel (1)
1-1: LGTM!src_assets/common/assets/web/styles/welcome.less (1)
13-13: LGTM!src_assets/common/assets/web/views/Home.vue (1)
373-373: LGTM!Also applies to: 394-394, 501-501, 545-545, 610-617, 767-767
src_assets/common/assets/web/components/common/ResourceCard.vue (1)
130-138: LGTM!Also applies to: 150-152, 169-171, 194-194, 282-282
src_assets/common/assets/web/components/common/ResourceLink.vue (1)
105-106: LGTM!Also applies to: 125-126, 173-178
src_assets/common/assets/web/views/Apps.vue (1)
4-4: LGTM!src_assets/common/assets/web/views/Config.vue (1)
130-130: LGTM!src_assets/common/assets/web/views/Pin.vue (1)
5-5: LGTM!src_assets/common/assets/web/public/assets/locale/en.json (1)
775-775: LGTM!src_assets/common/assets/web/public/assets/locale/zh.json (1)
775-775: LGTM!
1 participant
改了啥呀
为啥要改
首页的文字和资源卡片被压得太紧，和 Apps、配置等页面的视觉节奏不一致。现在首页终于不用像被缩小一圈的杂鱼了。
验证
npm run test:webui（74 passed）npm run build