fix(windows): harden VDD control transport#817
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (1)src/**/*.{cpp,c,h}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (3)
Summary by CodeRabbit
Walkthrough更新 VDD legacy named-pipe 连接的安全标志,补充 IOCTL 句柄归属说明,并更新 sunshine-control-panel 子模块提交。 ChangesVDD 管道与 IOCTL 更新
控制面板子模块更新
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
改了啥呀
TargetProcessId必须等于发起 IOCTL 的进程为啥要改
Foundation 同时兼容新版 IOCTL 和旧版命名管道。这里补齐客户端侧的管道防冒充约束,并让 ABI 文档、控制面板和驱动实现保持一致;权限边界就不会被杂鱼兼容路径悄悄绕开啦。
验证
vdd_utils.cpp独立对象编译通过(MSYS2 UCRT64)npm run build:renderer通过cargo check --locked通过