feat(ds4): add updateFlags byte for output callback#33
Open
AhmedAmrNabil wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an
UpdateFlagsbyte to the DualShock4OutputStatestruct and updates the corresponding libVIIPER callbacks.When an output report is received for a DualShock4 device, it contains LED data, rumble data, flash data, and an update byte indicating which fields are valid:
This PR adds that update byte to the
OutputStatestruct so consumers can tell which fields changed.Related Issue
Fixes #32
Motivation and Context
Previously, output callbacks only delivered the raw 7 bytes (rumble, LED, flash) with no way to know which of them actually changed. Without the update flags, consumers had no way to distinguish a rumble-only update from an LED-only update or a combination of both. This change exposes that information directly.
How Has This Been Tested?
Type of Change
Checklist