Skip to content

Fix .wav audio upload#340

Open
gwigz wants to merge 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/fix-audio-upload
Open

Fix .wav audio upload#340
gwigz wants to merge 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/fix-audio-upload

Conversation

@gwigz

@gwigz gwigz commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Restores unsigned char and casts the read() calls to (char*), matching encode_vorbis_file.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 50f61076-9d1b-46a2-b2d6-3b74061273f2

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0c919 and 37932ba.

📒 Files selected for processing (1)
  • indra/llaudio/llvorbisencode.cpp

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of certain WAV files during audio encoding checks, reducing the chance of misreading header bytes and rejecting valid files.

Walkthrough

The wav_header buffer in check_for_invalid_wav_formats was changed from char[44] to unsigned char[44], with both infile.read calls updated to use an explicit (char*) cast to match the new buffer type.

Changes

WAV Header Buffer Type Update

Layer / File(s) Summary
Buffer type and read call fix
indra/llaudio/llvorbisencode.cpp
wav_header changed from signed to unsigned char array; both infile.read calls updated with (char*) casts to match.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A little buffer, once signed and shy,
Now wears unsigned bytes, standing tall and spry.
Two reads recast with a careful hop,
This rabbit thumps its paw — bug-fix, non-stop! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too brief and omits the required template sections, including issue link, checklist, and additional notes. Expand the description to fill the template sections: add context, a related issue link, checklist confirmations, and any extra notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing .wav audio upload handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant