CI: Use ubuntu-24 to run specs - #3582
Merged
Merged
Conversation
Ubuntu 24.04 is the latest LTS and new default runner image on github actions. We need to add ImageMagick for dragonfly storage adapter tests since the Ubuntu 24.04 image no longer includes it by default.
This tests must not run, if we test the ActiveStorage adapter. Since Ubuntu 24.04 imagemagick needs to be installed manually and we only do that for dragonfly storage adapter tests.
Cache /var/cache/apt/archives directly so apt-get automatically uses cached .deb files. The previous custom cache directory approach was not working because apt doesn't look there by default. Also simplified apt install commands and bumped cache key version to invalidate old caches.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 314 314
Lines 8170 8170
=======================================
Hits 7960 7960
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 314 314
Lines 8170 8170
=======================================
Hits 7960 7960
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We only need to build js packages if package.json changed. Since github skips following jobs, if this job was skipped, we need to run the jobs also if the build job was skipped. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Use always() to ensure the if condition is evaluated when the build_javascript job is skipped due to no package.json changes.
Version 6 improves credential security by storing credentials in a separate file under $RUNNER_TEMP instead of directly in .git/config.
Ensures consistent runner environment across all CI jobs.
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Updates the runner image from Ubuntu 22 to Ubuntu 24 and install imagemagick for Dragonfly based tests, because the default runner image does not contain imagemagick anymore.
Also fixes apt package caching.
Checklist