Open
Conversation
src/karapace/core/serialization.py
Outdated
| else: | ||
| data = flatten_unions(schema.schema, value) | ||
| flattened = flatten_unions(schema.schema, value) | ||
| data = convert_logical_types(schema.schema, flattened) |
Contributor
There was a problem hiding this comment.
do we need this declaration ?
src/karapace/core/serialization.py
Outdated
| return value | ||
|
|
||
|
|
||
| def convert_logical_types(schema: avro.schema.Schema, value: Any) -> Any: |
Contributor
There was a problem hiding this comment.
I think this needs a docstring explaining its purpose, which types it handles, etc
src/karapace/core/serialization.py
Outdated
|
|
||
| # Timestamps | ||
| if logical_type == "timestamp-millis" and isinstance(value, int): | ||
| epoch = datetime.datetime(1970, 1, 1, tzinfo=datetime.timezone.utc) |
Contributor
There was a problem hiding this comment.
nit - these constants are recreated on every call.
muralibasani
force-pushed
the
rest-avro-logical-types
branch
from
0ca3b53 to
0bd4434
Compare
…nto rest-avro-logical-types
…cimal and ts as string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Avro logical types:
New config flag:
rest_avro_extended_json_parser: bool = False # default: Confluent-compatible behaviour
When True: