Skip to content

feat: scaffold internal audit tool with FastAPI + Google Ads connector#13

Closed
Hello-yellow-fornya wants to merge 4 commits intoAgriciDaniel:mainfrom
Hello-yellow-fornya:claude/review-repo-assessment-69pij
Closed

feat: scaffold internal audit tool with FastAPI + Google Ads connector#13
Hello-yellow-fornya wants to merge 4 commits intoAgriciDaniel:mainfrom
Hello-yellow-fornya:claude/review-repo-assessment-69pij

Conversation

@Hello-yellow-fornya
Copy link
Copy Markdown

Adds the foundation for an internal web-based Google Ads audit tool:

  • FastAPI config and settings module
  • SQLAlchemy models (accounts, audits, check results)
  • Google Ads API connector with OAuth flow and 13 GAQL queries
  • Project structure for auditors, services, and API endpoints

https://claude.ai/code/session_01C3E5wwTHTmzMoKbAVRjj6e

Summary

Briefly describe what this PR does and why.

Type of Change

  • Bug fix
  • New sub-skill or feature
  • Reference file update (benchmarks, specs, audit checks)
  • Documentation
  • Other (describe):

Checklist

  • Tested against a sample ad account (if applicable)
  • SKILL.md files are under 500 lines
  • Reference files are under 200 lines
  • Python scripts output valid JSON
  • Shell scripts use set -euo pipefail
  • No credentials or API keys in the diff

Related Issues

Closes #

claude added 4 commits March 25, 2026 03:53
Adds the foundation for an internal web-based Google Ads audit tool:
- FastAPI config and settings module
- SQLAlchemy models (accounts, audits, check results)
- Google Ads API connector with OAuth flow and 13 GAQL queries
- Project structure for auditors, services, and API endpoints

https://claude.ai/code/session_01C3E5wwTHTmzMoKbAVRjj6e
Next.js frontend with dashboard, score gauge, and check cards.
FastAPI backend with 23 weighted audit checks, Google Ads connector,
OAuth flow, and async audit runner. Includes Docker and Railway configs.

https://claude.ai/code/session_01C3E5wwTHTmzMoKbAVRjj6e
Full codebase review covering architecture, 190 audit checks,
scoring system, benchmarks, compliance, scripts, and the new
application layers. Includes prioritized recommendations.

https://claude.ai/code/session_01C3E5wwTHTmzMoKbAVRjj6e
Comprehensive brief covering architecture, tech stack, all 23 audit
checks, API endpoints, database schema, auth flow, known gaps, and
development guidelines. Intended to onboard Claude Code on the
ads-audit-tool as a standalone repository.

https://claude.ai/code/session_01C3E5wwTHTmzMoKbAVRjj6e
@AgriciDaniel
Copy link
Copy Markdown
Owner

Impressive engineering work! A FastAPI-based internal audit tool with SQLAlchemy models, Google Ads OAuth, and 13 GAQL queries is a solid foundation.

However, this is a full web application (+3,865 lines, 52 files) which is out of scope for a Claude Code CLI skill repo. Claude Ads is designed to run entirely within Claude Code without external services.

I'd strongly encourage you to publish this as a standalone project — there's clearly demand for a web-based ad audit tool, and you've built a great start. Happy to link to it from our README if you release it!

AgriciDaniel added a commit that referenced this pull request Apr 1, 2026
- Upstream 10 Google Ads audit accuracy fixes from community fork (akarls-web),
  eliminating ~600 false positives across G03, G04, G12, G16, G17, G19, G48, G-CT1
- Cherry-pick 6 validation gates from PR #12 (Tessl) for data quality enforcement
- Add Google Ads MCP integration for optional automated data collection
- Create marketplace.json for plugin system discoverability (Issue #14)
- Add GAQL compatibility reference (gaql-notes.md) with deduplication patterns
  and legacy BMM detection heuristic
- Update Dependabot deps: actions/checkout v6, setup-python v6, Pillow <13.0.0
- Align version to 1.3.0 (was incorrectly 2.0.0 in plugin.json)

PR triage: Closed #4, #5, #13 (out of scope); cherry-picked #12; merged #8, #9, #10
Issues: Closed #14 (marketplace.json shipped)
Community: Replied to Discussion #11

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants