fix: mixed content, external links, --help, and crash recovery - #171
Open
pol4rfuchs wants to merge 1 commit into
Open
fix: mixed content, external links, --help, and crash recovery#171pol4rfuchs wants to merge 1 commit into
pol4rfuchs wants to merge 1 commit into
Conversation
- allowRunningInsecureContent: true — fixes subscribing to self-hosted http:// instances from the https:// ntfy.sh web UI (mixed content was silently blocked by Chromium, button click registered but request never fired) (Aetherinox#139) - will-navigate handler — links clicked inside the app now open in the system browser instead of navigating the main window away (Aetherinox#155) - --help/-h now prints usage and exits before any window is created, instead of silently starting the app (Aetherinox#158) - render-process-gone handler — reload instead of a dead/white window if the loaded ntfy.sh or self-hosted web UI crashes on its own (Aetherinox#162, root cause is upstream frontend code, this only recovers from it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--helpand-hjust start the program without any indication the program supports CLI args #158)Pull Request
Select which topic best describes your contribution:
Description
Explain here what your pull request includes and what you've done
Before You Submit
Please ensure you check the following items to indicate that you've read this section and completed each task