Add not, fix partial writes, parser corrections#73
Merged
protz merged 1 commit intoAeneasVerif:mainfrom Apr 15, 2026
Merged
Conversation
protz
approved these changes
Apr 15, 2026
| ret { s with dmem := s.dmem.insert (.ofBitVec addr) (.ofBitVec (old.toBitVec.replaceLow v)) } | ||
| | .none => | ||
| if h: w = .W64 then | ||
| -- We know how to perform full writes even though there is not previous |
There was a problem hiding this comment.
This differs from bedrock2 semantics. In bedrock2, None means that this address is unmapped and writing to it is forbidden. @andres-erbsen do you want to change this?
Collaborator
There was a problem hiding this comment.
then we'd need three cases, to express known value / unknown value / forbidden address?
There was a problem hiding this comment.
In bedrock2, we don't have a third case for "unknown value", and instead use universal quantification.
Collaborator
Author
There was a problem hiding this comment.
I have reverted this part of the change and made some adaptions to the test instead, see #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an unchanged copy of the part of #65 that fixed tests. Locally, they are all passing for me now, but as mentioned in the PR there will probably still be some failures in the CI / on other architectures regarding flags that are undefined after the test.
@protz are you happy with these as they are, or would like me to do some changes before merging?