Prepare for Lean machine integers#948
Open
abentkamp wants to merge 2 commits intoAeneasVerif:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes in preparation for migrating the official Lean machine integers:
.valto.toNat/.toIntand.bvto.toBitVec. The goal is to align the naming conventions with ones of the official Lean library. This will make the next step of replacing our custom machine integers with Lean's machine integers easier. In particular, the diffs will be smaller and easier to review.These two changes are separated cleanly into one commit each for easier review of this PR.