Fix: Set configured timeouts as default RequestConfig on HTTP client#1795
Draft
Fix: Set configured timeouts as default RequestConfig on HTTP client#1795
Conversation
Co-authored-by: gcatanese <1771700+gcatanese@users.noreply.github.com>
Co-authored-by: gcatanese <1771700+gcatanese@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Bug] Fix Adyen HTTP client timeout issue
Fix: Set configured timeouts as default RequestConfig on HTTP client
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectionTimeoutMillis,readTimeoutMillis, andconnectionRequestTimeoutMillisfromConfigwere applied per-request but never set as the defaultRequestConfigon theCloseableHttpClientitself — leaving the client with no timeout fallback and allowing requests to run far beyond configured limits under adverse network conditions.Changes
AdyenHttpClient: PassConfigintocreateHttpClientWithSocketFactoryand callsetDefaultRequestConfig()with the configured timeouts when building the HTTP client:AdyenHttpClient: MadecreateCloseableHttpClientpackage-private to allow direct unit testing.ClientTest: Added tests verifying that the HTTP client's defaultRequestConfigreflects both custom and default timeout values fromConfig.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.