Add dark-background nib mark variant - #238
Merged
Merged
Conversation
Signed-off-by: Jason Odoom <jason@adastracomputing.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
ink-nib.svgusesfill="currentColor"and an opaque white eyelet. Loaded through<img src>,currentColorresolves to the SVG's own black default rather than the host page, so the mark is always dark and vanishes on dark backgrounds.This adds
ink-nib-light.svg, a white nib whose eyelet is a real transparent hole viafill-rule="evenodd", so it reads cleanly on any dark tone. The existing light-background nib is untouched, this is additive. Naming follows the existingsign-in-with-ink-light.svgconvention where-lightis the light-colored asset for dark backgrounds.Brand README updated to list both variants.