fix: browser query passes literal {default_limit} instead of 100#110
Conversation
The browser-related query block in fullDesktopQuery used a plain
triple-quoted string instead of an f-string, so {default_limit} was
passed as a literal string to the query engine rather than being
replaced with 100.
The base query block above already used an f-string correctly for
the same variable.
Greptile SummaryThis PR fixes a bug where the browser query block inside
Confidence Score: 5/5Safe to merge — this is a single-character typo fix that corrects a silent data corruption in the browser query path. The change correctly adds the No files require special attention — only Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[fullDesktopQuery called] --> B["Build base query (f-string)\napp_events = limit_events(app_events, 100)\ntitle_events = limit_events(title_events, 100)"]
B --> C{params.bid_browsers?}
C -- Yes --> D["Append browser block (f-string) ✅ fixed\nbrowser_urls = limit_events(browser_urls, 100)\nbrowser_domains = limit_events(browser_domains, 100)"]
C -- No --> E["Append empty browser block (plain string)\nbrowser_events = []\nbrowser_urls = []"]
D --> F["Append RETURN block (plain string)"]
E --> F
F --> G[Return query string]
Reviews (1): Last reviewed commit: "fix: use f-string for browser query so d..." | Re-trigger Greptile |
The browser query block in
fullDesktopQueryuses a plain"""string, but{default_limit}only gets interpolated inside an f-string.The base query block a few lines above already uses
f"""correctly for the same variable — the browser block just missed thefprefix.One-character fix: add
fto the string prefix.