feat: more mutation test cases for immutable detector#26
Open
taasbaba wants to merge 1 commit intoAckee-Blockchain:mainfrom
Open
feat: more mutation test cases for immutable detector#26taasbaba wants to merge 1 commit intoAckee-Blockchain:mainfrom
taasbaba wants to merge 1 commit intoAckee-Blockchain:mainfrom
Conversation
- added tests for lamports zeroing with chained calls and to_account_info() - added test for replacing whole account struct - added test for UncheckedAccount lamports change - added test for calling &mut self methods on immutable accounts - added two negative tests to avoid false alarms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
ImmutableAccountMutatedDetectorto cover more mutation patterns that can slip past the current checks, and adds a couple of negative tests to make sure it doesn’t false positive.Key changes
Added detection for:
try_borrow_mut_lamports()to_account_info()variantUncheckedAccount&mut selfon an immutable accountTest updates:
Verification
Related Tickets & Documents