Open
Conversation
Collaborator
|
Hi @AnaCarolinaChaves thanks for this. I do not have access to a Mac so unfortunately cannot test... @nicolocarpignoli @kalwalt do you have access to Mac? |
Collaborator
|
... Mac or iPhone (i.e. device with Safari) |
Member
|
No i haven't, can't test this |
drewish
reviewed
Nov 14, 2021
| @@ -1,264 +0,0 @@ | |||
| <!DOCTYPE html> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It removes the first prompt that appears on Safari that asks to tap the screen
Can it be referenced to an Issue? If so what is the issue # ?
No issue, just something that was seen while testing
How can we test it?
If, for instance, you run the aframe-ar on an apple device using Safari the prompt should now be different.
Summary
When using Safari, before asking to grant camera permissions an alert would appear asking to tap the screen to grant geolocation permissions.
Does this PR introduce a breaking change?
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
It should be used an iOS 13+ device with Safari
Other information