Replace deprecated request with native fetch - #68
Merged
jonathan-r-thorpe merged 2 commits intoJul 29, 2026
Conversation
jonathan-r-thorpe
approved these changes
Jul 29, 2026
jonathan-r-thorpe
left a comment
jonathan-r-thorpe
left a comment
Contributor
There was a problem hiding this comment.
Apart from the pre-existing typo ( "applicatio/sdp") it LGTM
Drop request and request-promise-native so global installs no longer pull in the deprecated request/har-validator/uuid stack. Node 18+ provides fetch natively, matching the CI Node versions. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
garethsb
force-pushed
the
replace-deprecated-request
branch
from
July 29, 2026 13:44
47783ba to
f065218
Compare
Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request/request-promise-nativeingetSDP()with Node's built-infetchnpm install -g(e.g. from nmos-testing CI) no longer pulls in the deprecatedrequest/har-validator/uuid@3stackTest plan
npm test(29/29)npm run lintnpm install -g git+https://github.com/...and check that the request deprecation warnings are gone