ST 2110 improvements - #57
Merged
Merged
Conversation
Contributor
|
Hi @knneth. I've recently pushed some functional tests to the master branch. Would you be happy to rebase or merge to master to add those tests to your PR so we can be confident the PR doesn't introduce any regressions? Better than that, would you be happy to add an example SDP file to the Even better than that, would you add a negative example in the Many thanks 👍 |
strean should be stream. Signed-off-by: Kenneth Klette Jonassen <kenneth@bridgetech.tv> Reviewed-by: Kai Hagseth <kai.hagseth@bridgetech.tv>
The width and height parameters are mandatory per ST 2110-22:2022 Section 7.2. Their presence was already checked, but not their values. Signed-off-by: Kenneth Klette Jonassen <kenneth@bridgetech.tv> Reviewed-by: Kai Hagseth <kai.hagseth@bridgetech.tv>
Prepare for upcoming commit to introduce a new ST 2110-10 test by deduplicating the existing arrays of tests for ST 2110-10. Signed-off-by: Kenneth Klette Jonassen <kenneth@bridgetech.tv>
The MAXUDP parameter is specified in ST 2110-10 and common for several RTP payloads, not just ST 2110-20. Update the reference used for the MAXUDP test and enable it for all ST 2110 SDPs. Furthermore, the UDP size limits defined in ST 2110-10 are upper bounds rather than specific permitted values of MAXUDP. Change it to a range check. No specific lower bound is mentioned in ST 2110-10, but the shortest possible UDP datagram that may contain an RTP header is 20 bytes, so this is implied to be the lowest common lower bound of any current or future RTP payload type. Signed-off-by: Kenneth Klette Jonassen <kenneth@bridgetech.tv> Reviewed-by: Kai Hagseth <kai.hagseth@bridgetech.tv>
Signed-off-by: Kenneth Klette Jonassen <kenneth@bridgetech.tv>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves MAXUDP validation, adds width/height validation for ST 2110-22, and a few minor code changes.