Initialize dt when restarting from plt#623
Merged
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom Feb 12, 2026
Merged
Initialize dt when restarting from plt#623baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 3 commits intoAMReX-Combustion:developmentfrom
Conversation
d-montgomery
force-pushed
the
set-dt-from-plt
branch
from
089fdbc to
e4452c0
Compare
Tested with amr.dt_shrink and amr.dt_change_max
baperry2
approved these changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an initialization bug when restarting from plotfiles with peleLM.initDataPlt_reset_time = 0. The issue occurred because m_dt and m_prev_dt were not initialized when reading from plotfiles (which don't contain timestep information), causing them to remain at their default value of -1.0. This led to the error "Estimated dt -1.1 is below allowed dt_min" during the first timestep calculation.
Changes:
- Initialize
m_dtandm_prev_dtwhen restarting from plotfiles withm_do_reset_time = 0 - Set both to
m_fixed_dtif using fixed timestepping - Set both to
AMREX_REAL_MAXif using CFL-based timestepping
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error when restarting from plt files with
peleLM.initDataPlt_reset_time = 0.m_dtandm_prev_dtwere not being initialized causing the following error:This PR sets
m_dtandm_prev_dtbased on the fixed time step in the input file. Ifamr.cflis specified by the user,m_dtandm_prev_dtare set to large values which are then updated during the CFL calculation.