Fix TA-Lib integration and clean up indicator library selection#359
Merged
BruceYanghy merged 3 commits intoAI4Finance-Foundation:masterfrom Mar 25, 2026
Merged
Fix TA-Lib integration and clean up indicator library selection#359BruceYanghy merged 3 commits intoAI4Finance-Foundation:masterfrom
BruceYanghy merged 3 commits intoAI4Finance-Foundation:masterfrom
Conversation
- improve technical indicator lib selection - unify technical indicators processing design - fix some bugs with the data processing
for more information, see https://pre-commit.ci
Contributor
Author
Member
|
Thanks for the fixes — this addresses several real issues in the TA‑Lib path. Key wins:
I’m in favor of merging once CI is green. The only behavior change to be mindful of is the default drop_na_timesteps and the TA‑Lib indicator whitelist (e.g., rsi vs rsi_30). If CI passes, this looks good to go. |
133de6d
into
AI4Finance-Foundation:master
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Addressing a few issues with the TA-Lib path (select_stockstats_talib=1):
This is a follow-up to FinRL PR #1344 (already ported in #353), which fixed the auto_adjust / OHL adjustment in YahooDownloader. That addressed the data ingestion side — this one covers the indicator computation layer.
Further improvements: