Skip to content

Conversation

@aurelius-adrian
Copy link

The default resolver template for code generation is altered such that, the directives that are called are listed in the comment area above the resolver function definition. Parameters of the directives are also included in the output.

This PR closes my issue #3762

As this is a very minor (non-functional) feature, I have not included the following items ->
I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

… resolver_test.go with altered testdata/schema.graphql to demonstrate functionality
@aurelius-adrian aurelius-adrian changed the title feat: added functionality to add directives to resolver comments; ran… Add Directives to Resolver Comments Jul 14, 2025
@coveralls
Copy link

Coverage Status

coverage: 73.134%. remained the same
when pulling 8f1e701 on aurelius-adrian:master
into fadac6f on 99designs:master.

@StevenACoffman
Copy link
Collaborator

@aurelius-adrian This has PR causes a number of CI failures for our fmt-and-generate. This will have a similar effect for anyone who uses this in their own systems, so I think you should add a config option to allow people to opt-in to this new behavior. I think it is valuable, but I think that some people might want to keep their comments more succinct.

@aurelius-adrian
Copy link
Author

@StevenACoffman I will try to look at it to add an option in the config file and resubmit.

@StevenACoffman
Copy link
Collaborator

@aurelius-adrian Is this something you are still planning on resubmitting?

@aurelius-adrian
Copy link
Author

Yes, although I am currently involved in other projects and will likely only get to it in mid October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants