add extraContainers support

[ArnaudTA]

basic support for extraContainers support.

Totally inspired by the Vault chart:
https://artifacthub.io/packages/helm/hashicorp/vault

Have a good day :)

Summary by CodeRabbit

• New Features

  • Support for adding extra (sidecar) containers to main, worker, and webhook deployments via Helm values.
  • Allows injecting custom containers alongside primary containers to extend functionality (e.g., logging, metrics, proxies).

• Documentation

  • Helm values updated to document new extraContainers fields and include example sidecar entries for each deployment type.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds support for injecting user-defined extra containers (sidecars) into main, worker, and webhook Helm deployment templates via new extraContainers fields in values.yaml; templates conditionally render and append the provided YAML into each pod's containers list when defined.

Changes

Cohort / File(s)	Change Summary
Main deployment charts/n8n/templates/deployment.yaml	Conditionally render and append main.extraContainers into the pod containers list using tpl(toYaml(...)) when defined.
Worker deployment charts/n8n/templates/deployment.worker.yaml	Conditionally render and append worker.extraContainers into the pod containers list using tpl(toYaml(...)) when defined.
Webhook deployment charts/n8n/templates/deployment.webhook.yaml	Conditionally render and append webhook.extraContainers into the pod containers list using tpl(toYaml(...)) when defined.
Values charts/n8n/values.yaml	Added extraContainers: null entries (with example snippet) under main, worker, and webhook to expose sidecar configuration.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HelmChart
    participant Kubernetes
    User->>HelmChart: Add extraContainers in values.yaml (main/worker/webhook)
    HelmChart->>HelmChart: tpl(toYaml(.Values.*.extraContainers)) -> render YAML snippets
    HelmChart->>Kubernetes: Apply rendered deployments (pods include extra containers)
    Kubernetes-->>User: Pods created with main + extra sidecar containers

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'add extraContainers support' directly and clearly describes the main change: adding support for extraContainers to the Helm chart across three deployment templates and values file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (4)

charts/n8n/values.yaml (2)

451-452: Repeat usage example suggestion. The same guidance for documenting main.extraContainers applies here under worker.extraContainers.

---

639-640: Repeat usage example suggestion. The same guidance for documenting main.extraContainers applies here under webhook.extraContainers.

charts/n8n/templates/deployment.worker.yaml (1)

117-119: Repeat Helm templating suggestion. Wrap the extraContainers rendering in tpl to permit templating inside sidecar definitions, mirroring the initContainers approach.

charts/n8n/templates/deployment.webhook.yaml (1)

121-123: Repeat Helm templating suggestion. Wrap the extraContainers rendering in tpl to permit templating inside sidecar definitions, mirroring the initContainers approach.

🧹 Nitpick comments (1)

charts/n8n/values.yaml (1)

263-264: Add usage example for extraContainers. It would be helpful to include a commented snippet in values.yaml showing how to configure sidecar containers, for example:

# extraContainers:
#   - name: my-sidecar
#     image: busybox:latest
#     command: ["sh", "-c", "echo hello"]

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 565fbf7 and e2d877a.

📒 Files selected for processing (4)

• charts/n8n/templates/deployment.webhook.yaml (1 hunks)
• charts/n8n/templates/deployment.worker.yaml (1 hunks)
• charts/n8n/templates/deployment.yaml (1 hunks)
• charts/n8n/values.yaml (3 hunks)

[ArnaudTA]

anybody here ?

[devshark]

I need this to enable cloudsql proxy sidecar

[raivil]

+1 for this feature

[LeoDiazL]

I would recommend adding a note about this in the README, explaining that this would be a container running in the same pod, and that because of that, Kubernetes expects it to stay running.

[cloudwithdan]

Need this feature also, thanks @LeoDiazL !

[obsidian33]

@ArnaudTA are you able to push this along? if not I can pick it back up in a separate PR and reference this one. I really want to get this merged in.

[obsidian33]

@LeoDiazL I addressed your comments in #252

[ArnaudTA]

Hello, suggestions applied, are you ok to merge ?

[arthurgbranco]

Can we approve and merge this? Really need this feature.
cc. @Vad1mo

edit: For anyone seeing, for my use case, I was able to resolve my issue by using this:
#252 (review)