update cli with new methods: SetString(), GetString(), and so.#2
Merged
Conversation
…memory-database into feat/update-cli-cmds
…pdate usage.go usages in cli.
…alue given is 0).
…o uint, if yes then utilised SetInt() (but after converting to type uint32), if not then utilised SetString() func).
…re stored in same map, GetInt() blindly converts data to uint32 without knowing if value is type string, so i added a temporary fallback to check if len(data) is not 4 bytes in total, meaning that its a string, and by doing so the other fallback logic in GET cmd (main.go) can execute.)
… with unsafe fallback logic if GetInt() blindy interprets value as string).
… values are available for b.GetAllInt (basically a fallback), but very unsafe and not tested).
…value type int exists before checking if its string, otherwise there is no data available.)
… (working as of now but will optimise fallbacks to safer methods).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.