Skip to content

Update tr.json#895

Open
OnurGVNGL wants to merge 1 commit into
4gray:masterfrom
OnurGVNGL:master
Open

Update tr.json#895
OnurGVNGL wants to merge 1 commit into
4gray:masterfrom
OnurGVNGL:master

Conversation

@OnurGVNGL

Copy link
Copy Markdown

The Turkish translation of the program was of terrible quality. The translation was redone from scratch using the en.json file. This translation was entirely done by OnurGVNGL, the owner of onur.net.tr. Thank you for providing us with the program. You can always reach me at onur@onur.net.tr. I don't know if there's a section for those who support the program, but I'd like to see my name. Regards.

The Turkish translation of the program was of terrible quality. The translation was redone from scratch using the en.json file. This translation was entirely done by OnurGVNGL, the owner of onur.net.tr. Thank you for providing us with the program. You can always reach me at onur@onur.net.tr. I don't know if there's a section for those who support the program, but I'd like to see my name. Regards.
@greptile-apps

greptile-apps Bot commented May 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR replaces the previous Turkish (tr.json) translation with a full rewrite authored by OnurGVNGL, translating every key from en.json into natural Turkish. All 188 modified keys are present, and every {{placeholder}} token (e.g. {{count}}, {{type}}, {{name}}, {{current}}/{{total}}) is preserved correctly.

  • Complete key coverage: No keys from en.json are missing in the new translation; nested structures (WORKSPACE.SHELL.COMMANDS, HOME.PLAYLISTS.REFRESH_XTREAM_DIALOG, etc.) are all fully translated.
  • Placeholder integrity: All interpolation tokens carry over verbatim, so runtime string substitution will work as expected.
  • Formatting inconsistency: Roughly 30 lines across the file use a hard tab character for indentation while the rest of the file uses four spaces; this doesn't break JSON parsing but may trigger formatter or linter warnings in CI.

Confidence Score: 4/5

Safe to merge — translation-only update with no logic changes, no missing keys, and no broken placeholders.

The translation is thorough and complete with full key coverage and all placeholders intact; the only finding is inconsistent whitespace (mixed tabs and spaces) scattered across ~30 lines with no runtime impact.

apps/web/src/assets/i18n/tr.json — mixed-indentation lines are spread throughout; a single pass with a JSON formatter (e.g. prettier) would resolve them all at once.

Important Files Changed

Filename Overview
apps/web/src/assets/i18n/tr.json Complete Turkish translation rewrite — all 188 changed keys cover the full en.json key set, all {{placeholder}} tokens are preserved, but mixed tabs/spaces indentation is scattered throughout the file.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["en.json (source of truth)"] -->|"translated key-by-key"| B["tr.json (this PR)"]
    B --> C{"i18n loader"}
    C -->|"key lookup at runtime"| D["UI component renders localized string"]
    C -->|"key missing"| E["Falls back to key name"]
    B --> F{"Mixed tabs+spaces in raw JSON"}
    F -->|"parseable but inconsistent"| G["JSON.parse() succeeds"]
    F -->|"linter/formatter may flag"| H["CI lint step may warn"]
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/web/src/assets/i18n/tr.json:197
**Mixed tabs and spaces throughout file**

Multiple keys in this file start with a hard tab character while surrounding lines use four-space indentation. This first occurrence is at `SETTINGS.TITLE` (line 197), but the pattern repeats across roughly 30 lines (e.g. lines 259, 316, 359, 390, 423, 433, 440, 467, 504, 515, 525, and many more). JSON parsers ignore whitespace so runtime behaviour is unaffected, but if the project runs a JSON formatter or lint step the file may fail CI, and editors will render the indentation inconsistently.

Reviews (1): Last reviewed commit: "Update tr.json" | Re-trigger Greptile

},
"SETTINGS": {
"TITLE": "Ayarlar",
"TITLE": "Ayarlar",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Mixed tabs and spaces throughout file

Multiple keys in this file start with a hard tab character while surrounding lines use four-space indentation. This first occurrence is at SETTINGS.TITLE (line 197), but the pattern repeats across roughly 30 lines (e.g. lines 259, 316, 359, 390, 423, 433, 440, 467, 504, 515, 525, and many more). JSON parsers ignore whitespace so runtime behaviour is unaffected, but if the project runs a JSON formatter or lint step the file may fail CI, and editors will render the indentation inconsistently.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/src/assets/i18n/tr.json
Line: 197

Comment:
**Mixed tabs and spaces throughout file**

Multiple keys in this file start with a hard tab character while surrounding lines use four-space indentation. This first occurrence is at `SETTINGS.TITLE` (line 197), but the pattern repeats across roughly 30 lines (e.g. lines 259, 316, 359, 390, 423, 433, 440, 467, 504, 515, 525, and many more). JSON parsers ignore whitespace so runtime behaviour is unaffected, but if the project runs a JSON formatter or lint step the file may fail CI, and editors will render the indentation inconsistently.

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant