Open
Conversation
Member
|
Thanks a lot, Soo. We did not target Python 3.9 and 3.10 for now, but it's great that it seems to work without issues. The local tests are passing, right? We probably leave the lambdas at 3.8 for now. We just moved them to 3.8 and I don't want to risk breaking anything (even though it would most likely work) |
|
Hi @SooLee long time no see! Any chance to get the CI to run through for this? This PR is a blocker for getting the new snakemake tibanna plugin to work, see 4dn-dcic/snakemake-executor-plugin-tibanna#1. |
Member
Author
|
Hi Johannes, long time no see! I may be able to find some time in the next
few weeks. What exactly did you need?
…On Tue, Sep 12, 2023, 4:26 AM Johannes Köster ***@***.***> wrote:
Hi @SooLee <https://github.com/SooLee> long time no see! Any chance to
get the CI to run through for this? This PR is a blocker for getting the
new snakemake tibanna plugin to work, see
4dn-dcic/snakemake-executor-plugin-tibanna#1
<4dn-dcic/snakemake-executor-plugin-tibanna#1>.
—
Reply to this email directly, view it on GitHub
<#368 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLO3H7Q4Q3KMQ2KJX2T3LX2AMDVANCNFSM56J6NZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
I can release a new version of Tibanna that supports Python 3.9 and Python 3.10, if that is helpful. |
|
Yes, that would be all we need. Python 3.9 support is sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure which part got it to work though. It did remove this persistent error message upon deploy unicorn:
By the way, poetry 20.9 does not work but 21.3 does. With 20.9, entry point is not supported - you cannot type
tibannaat the command line.I also noticed that 2.0.0 doesn't get installed when you do
pip install tibanna. The previous version (1.9.2) definitely does not work on my Mac (with the lambda python version error above).I'm being a guinea pig.. just was trying to use tibanna for something.