Conversation
willronchetti
approved these changes
Jun 21, 2023
Member
willronchetti
left a comment
willronchetti
left a comment
There was a problem hiding this comment.
So long as this passes tests/deploys the change should be fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, we make a small update to functions involved in
request.embed()to propagate the parent requests stats to the subrequest and do some minor refactoring.Hit this bug when refactoring spreadsheet download code in cgap-portal previously written by Alex B. (see his comments here).
Note: wrapped propagation of the new attribute in a try/except clause to be conservative here given how central the function involved is.