Replace 'stout::Try' with 'tl::expected'#61
Draft
ArthurBandaryk wants to merge 2 commits intomainfrom
Draft
Conversation
ArthurBandaryk
force-pushed
the
artur.expected
branch
from
938ffec to
e03b94b
Compare
benh
reviewed
Jul 27, 2022
ArthurBandaryk
force-pushed
the
artur.expected
branch
2 times, most recently
from
2420a71 to
0e35234
Compare
CodingCanuck
approved these changes
Jul 27, 2022
ArthurBandaryk
force-pushed
the
artur.expected
branch
from
0e35234 to
6377471
Compare
CodingCanuck
approved these changes
Jul 27, 2022
Contributor
CodingCanuck
left a comment
CodingCanuck
left a comment
There was a problem hiding this comment.
Artur, is it intentional that this review is still in draft state?
Contributor
Author
Yep, because 3-rd phase with all replacement in 'include/stout' and 'tests' dirs is coming! |
ArthurBandaryk
force-pushed
the
artur.expected
branch
from
6377471 to
8e989ca
Compare
ArthurBandaryk
force-pushed
the
artur.expected
branch
from
8e989ca to
4763501
Compare
CodingCanuck
approved these changes
Jul 27, 2022
Contributor
CodingCanuck
left a comment
CodingCanuck
left a comment
There was a problem hiding this comment.
Nice! I love how there's a lot less explicit use of std::string in the test in this latest revision.
ArthurBandaryk
force-pushed
the
artur.expected
branch
from
4763501 to
13064e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
stout::Trywithstout::expectedwhich is just going to be an alias fortl::expected.