fix(xcode): debug signing config + SPM module resolution - #77
Merged
Conversation
Two bare print() calls on error paths replaced with FileLogger.shared.log(.error) so errors land in the app log file rather than stdout.
- Add WhisKey.Debug.entitlements (omits keychain-access-groups for local builds) and wire Debug config to use it with CODE_SIGN_IDENTITY="-", CODE_SIGN_STYLE=Manual, DEVELOPMENT_TEAM="", ENABLE_HARDENED_RUNTIME=NO so "My Mac" run destination works without a provisioning profile - Fix Metal script arg order: xcrun -sdk macosx metal (was xcrun metal -sdk macosx) - Remove duplicate Sources/WhisKeyCore from target sources; add WhisKeyCore, WhisKeyUI, and GRDB as explicit SPM product dependencies so the compiler resolves the modules correctly - Regenerate WhisKey.xcodeproj via xcodegen generate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WhisKey/WhisKey.Debug.entitlements(omitskeychain-access-groups, which requires a provisioning profile) and wired the Debug config to it:CODE_SIGN_IDENTITY: "-",CODE_SIGN_STYLE: Manual,DEVELOPMENT_TEAM: "",ENABLE_HARDENED_RUNTIME: NO. The "My Mac" destination now resolves without Xcode prompting for a team or profile.xcrun metal -sdk macosxis invalid; corrected toxcrun -sdk macosx metal.WhisKeyCore,WhisKeyUI,GRDB) — The target hadSources/WhisKeyCorelisted undersources, causing the compiler to treat it as loose source files rather than a package product. Removed that entry and added all three as explicit SPMdependenciesproducts. RegeneratedWhisKey.xcodeprojviaxcodegen generate.Test plan
WhisKey.xcodeprojin Xcodexcrun -sdk macosx metal)