chore: strip debug artifacts — replace print() with FileLogger#76
Open
rdemeritt wants to merge 1 commit into
Open
chore: strip debug artifacts — replace print() with FileLogger#76rdemeritt wants to merge 1 commit into
rdemeritt wants to merge 1 commit into
Conversation
Two bare print() calls on error paths replaced with FileLogger.shared.log(.error) so errors land in the app log file rather than stdout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print()calls inAudioCaptureService.swiftwithFileLogger.shared.log(.error, ...)so errors land in the app log file instead of stdout#if DEBUG migrator.eraseDatabaseOnSchemaChange = trueinDatabase.swift— correctly guarded, left in place (dev-only, stripped from release builds automatically)Logger.debug()calls across the codebase — OS Logger.debuglevel is a no-op in release builds; no action neededAudit scope
84 Swift files scanned. No
assert/assertionFailure,NSLog,debugPrint,TODO/FIXME, or hardcoded test values found.Test plan
Build complete! 3.31s)