Include source files in npm package for sourcemap resolution #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include TypeScript source files (.ts, .tsx) in the npm package files array to fix sourcemap warnings in downstream projects using vitest or other tools that try to resolve sourcemap references. This follows the wagmi/viem approach where source files are bundled alongside compiled output so sourcemaps can correctly point to original sources.
AlexanderKolberg
requested review from
a team and
0xsequence-bot
as code owners
Deploying web-sdk-react-example with
|
| Latest commit: |
18358ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61a6d4c1.web-sdk-react-example.pages.dev |
| Branch Preview URL: | https://fix-include-source-files-for.web-sdk-react-example.pages.dev |
AlexanderKolberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds source files (.ts, .tsx) to the npm package so sourcemaps actually resolve properly
Right now vitest and similar tools throw hundreds of warnings like "Sourcemap points to missing source files" because the sourcemaps reference .ts files that aren't in the package