Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dac7a9a07
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| go 1.24.0 | ||
|
|
||
| toolchain go1.24.2 | ||
| go 1.25.0 |
There was a problem hiding this comment.
Update CI toolchain to satisfy new Go minimum
Raising the module directive to go 1.25.0 here makes the repo require Go 1.25+, but the test workflow is still pinned to go-version: 1.24.x in .github/workflows/test.yml (line 18), so CI environments that disable auto toolchain downloads (or cannot reach proxy.golang.org) will fail before running tests with a go.mod requires go >= 1.25.0 error. Please bump that workflow to 1.25.x (or use go-version-file) in the same change so the minimum version and CI runtime stay consistent.
Useful? React with 👍 / 👎.
also bumps go to 1.25.0 minimum, as required by ethkit