fix(web): show target host/record in monitor header for TCP and DNS monitors - #270
Open
HartD92 wants to merge 1 commit into
Open
fix(web): show target host/record in monitor header for TCP and DNS monitors#270HartD92 wants to merge 1 commit into
HartD92 wants to merge 1 commit into
Conversation
Add a monitor target formatter for the detail header so TCP and DNS monitors show their configured endpoint instead of an empty target. Keep HTTP target rendering unchanged and hide the suffix when no target can be derived. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Deploy Preview for docspeekaping ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for peekaping ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The monitor detail header currently only renders the configured target for HTTP monitors. TCP and DNS monitors show just the monitor type with no indication of the host:port or DNS record being monitored, forcing users to open the edit dialog to confirm what each monitor is pointed at.
This PR adds a
formatMonitorTarget(monitor)helper that returns the most identifying configured value per monitor type, and uses it in the monitor view header. HTTP behavior is unchanged. TCP rendershost:port, DNS rendersrecord (type @ resolver:port).Changes
apps/web/src/app/monitors/view/format-monitor-target.ts- adds a small config parser/formatter for monitor header targets.apps/web/src/app/monitors/view/page.tsx- uses the formatter in the detail header and only links HTTP targets.Test plan
git diff --checkpassed.pnpm/corepack; installing dependencies withnpx pnpm@9.0.0 install --frozen-lockfilefailed withENOSPC: no space left on devicebefore eslint/tsc became available.apps/web/srcdoes not currently contain component/helper tests and I did not scaffold a new test framework.Notes
monitors.view.monitor_fortranslation is reused.