[vouch score] refactor walk to find all simple paths#406
Merged
Conversation
Contributor
|
For future reference here's the result of some benchmarking with production data: |
Contributor
|
For completness, we also tested a breadth first approach. While the numbers come out the same in the tests, with production data it's quick to exceed memory limits. This is what we would expect from a BFS vs DFS. Though it's possible it can be revisited in the future and tuned. |
dboreham
approved these changes
May 23, 2025
dboreham
pushed a commit
that referenced
this pull request
May 23, 2025
Co-authored-by: Lucietta De Staccato <lucietta_de_staccato@github.com> Co-authored-by: Archibald Fitz Hind <archibald_fitz_hind@github.com> Co-authored-by: Bea O'Tempo <bea_o'tempo@github.com> Co-authored-by: Gabi Beaver <gabi_beaver@github.com> Co-authored-by: Franci Tempo <franci_tempo@github.com> Co-authored-by: Rosina Fitz Lento <rosina_fitz_lento@github.com> Co-authored-by: Beauregard O'Sforzando <beauregard_o'sforzando@github.com> Co-authored-by: Basil Saint Urchin <basil_saint_urchin@github.com> Co-authored-by: Vale De Bittern <vale_de_bittern@github.com> Co-authored-by: Beauregard Legato <beauregard_legato@github.com> Co-authored-by: Chiaretta Saint Adagio <chiaretta_saint_adagio@github.com> Co-authored-by: Sandra Stag <sandra_stag@github.com> Co-authored-by: Vale McPiano <vale_mcpiano@github.com> Co-authored-by: Sofi Forte <sofi_forte@github.com> Co-authored-by: Archibald De Bittern <archibald_de_bittern@github.com> Co-authored-by: Paoletta De Lento <paoletta_de_lento@github.com> Co-authored-by: Mariella Legato <mariella_legato@github.com> Co-authored-by: Rosina Von Stag <rosina_von_stag@github.com> Co-authored-by: Rosina Fortissimo <rosina_fortissimo@github.com> Co-authored-by: Isa Saint Bittern <isa_saint_bittern@github.com> Co-authored-by: Isa McMezzo <isa_mcmezzo@github.com> Co-authored-by: Crispin Accelerando <crispin_accelerando@github.com> Co-authored-by: Mariella De Tempo <mariella_de_tempo@github.com> Co-authored-by: Rupert Von Cony <rupert_von_cony@github.com> Co-authored-by: Sofi Hart <sofi_hart@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.