Skip to content

Please do not introduce breaking changes without bumping major versionΒ #1506

@joachimbulow

Description

@joachimbulow

Dear contributors

Consider that commits such as this:

9f961e3

Really should not be merged as they introduce breaking functionality silently. As it happened for us - breaking production for any users with degraded internet.

5 seconds very very short for mobile clients, so at a minimum it should have been immediayely configurable. Preferably just nullable until set.

Due to this commit, it was set to 5 seconds, i reckon left from development, and now all downstream commits have all tagged along, setting the default timeout to 5 seconds.

Such as

b88fa9f
And
6180841

Thank you for contributions otherwise - love the library πŸ‘ got very spooked from this

Please consider this for the futuree, and let us close this issue again

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions