Merge pull request #615 from x-tools/preg-quote-uselang

samwilson · web-flow · commit 1e25e6d02cfb · 2026-01-22T07:53:07.000+08:00
Escape uselang param when checking against project name
diff --git a/src/EventSubscriber/RateLimitSubscriber.php b/src/EventSubscriber/RateLimitSubscriber.php
@@ -172,7 +172,7 @@ private function logCrawlers(): void {
 
 		// If requesting the same language as the target project, ignore.
 		// FIXME: This has side-effects (T384711#10759078)
-		if ( preg_match( "/[=\/]$useLang.?wik/", $this->uri ) === 1 ) {
+		if ( preg_match( '/[=\/]' . preg_quote( $useLang ) . '.?wik/', $this->uri ) === 1 ) {
 			return;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ private function logCrawlers(): void {`
`172`	`172`
`173`	`173`	`// If requesting the same language as the target project, ignore.`
`174`	`174`	`// FIXME: This has side-effects (T384711#10759078)`
`175`		`- if ( preg_match( "/[=\/]$useLang.?wik/", $this->uri ) === 1 ) {`
	`175`	`+ if ( preg_match( '/[=\/]' . preg_quote( $useLang ) . '.?wik/', $this->uri ) === 1 ) {`
`176`	`176`	`return;`
`177`	`177`	`}`
`178`	`178`