Replace obsolete Playwright RunAndWaitForNavigationAsync (#578)

Microsoft.Playwright 1.62 marks IPage.RunAndWaitForNavigationAsync as
obsolete, which produced 33 CS0612 warnings across the integration tests.

Playwright suggests WaitForURLAsync as the replacement, but that isn't
suitable here: every form under test POSTs back to the URL it was loaded
from, so the wait would match the URL of the page being navigated away
from and return immediately. Add a SubmitFormAsync extension that waits
for the navigation POST's response and then for the load state, and use
it at the 11 call sites.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: gunndabad

tests/GovUk.Frontend.AspNetCore.IntegrationTests/DateInputTests.cs

@@ -27,7 +27,8 @@ public async Task ForDateProperty()
         await page.FillAsync("[name='Date.Month']", month);
         await page.FillAsync("[name='Date.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped, including the invalid values
         await AssertFieldsForCompleteDate(page, day, month, year, expectDayToHaveError: true, expectMonthToHaveError: true, expectYearToHaveError: false, expectedErrorMessage: "Date of birth must be a real date");
@@ -51,7 +52,8 @@ public async Task ForCustomDateProperty()
         await page.FillAsync("[name='CustomDate.Month']", month);
         await page.FillAsync("[name='CustomDate.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped, including the invalid values
         await AssertFieldsForCompleteDate(page, day, month, year, expectDayToHaveError: true, expectMonthToHaveError: true, expectYearToHaveError: false, expectedErrorMessage: "Date of birth must be a real date");
@@ -75,7 +77,8 @@ public async Task ValueDateProperty()
         await page.FillAsync("[name='Date.Month']", month);
         await page.FillAsync("[name='Date.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped
         await AssertFieldsForCompleteDate(page, day, month, year);
@@ -99,7 +102,8 @@ public async Task ValueCustomDateProperty()
         await page.FillAsync("[name='CustomDate.Month']", month);
         await page.FillAsync("[name='CustomDate.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped
         await AssertFieldsForCompleteDate(page, day, month, year);
@@ -123,7 +127,8 @@ public async Task IndividualItemValues()
         await page.FillAsync("[name='Date.Month']", month);
         await page.FillAsync("[name='Date.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped
         await AssertFieldsForCompleteDate(page, day, month, year);
@@ -145,7 +150,8 @@ public async Task ForDatePartsProperty()
         await page.FillAsync("[name='MonthAndYear.Month']", month);
         await page.FillAsync("[name='MonthAndYear.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped, including the invalid values
         await AssertFieldsForMonthAndYearOnly(page, month, year, expectMonthToHaveError: true, expectYearToHaveError: false, expectedErrorMessage: "Month of birth must be a real date");
@@ -167,7 +173,8 @@ public async Task ForCustomDatePartsProperty()
         await page.FillAsync("[name='CustomMonthAndYear.Month']", month);
         await page.FillAsync("[name='CustomMonthAndYear.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped, including the invalid values
         await AssertFieldsForMonthAndYearOnly(page, month, year, expectMonthToHaveError: true, expectYearToHaveError: false, expectedErrorMessage: "Month of birth must be a real date");
@@ -189,7 +196,8 @@ public async Task ValueDatePartsProperty()
         await page.FillAsync("[name='MonthAndYear.Month']", month);
         await page.FillAsync("[name='MonthAndYear.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped
         await AssertFieldsForMonthAndYearOnly(page, month, year);
@@ -211,7 +219,8 @@ public async Task ValueCustomDatePartsProperty()
         await page.FillAsync("[name='CustomMonthAndYear.Month']", month);
         await page.FillAsync("[name='CustomMonthAndYear.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped
         await AssertFieldsForMonthAndYearOnly(page, month, year);
@@ -233,7 +242,8 @@ public async Task IndividualItemValuesForParts()
         await page.FillAsync("[name='MonthAndYear.Month']", month);
         await page.FillAsync("[name='MonthAndYear.Year']", year);
 
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Save" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify POSTed values have been round-tripped
         await AssertFieldsForMonthAndYearOnly(page, month, year);

tests/GovUk.Frontend.AspNetCore.IntegrationTests/FormElementValidationTests.cs

@@ -29,7 +29,8 @@ public async Task AllFormElements_WithValidationErrors_ShowErrorMessagesAndError
         await page.FillAsync("[name='DateInput.Year']", "2020");
 
         // Submit the form
-        await page.RunAndWaitForNavigationAsync(() => page.Keyboard.PressAsync("Enter"));
+        await page.GetByRole(AriaRole.Button, new() { Name = "Submit" }).ClickAsync();
+        await page.WaitForLoadStateAsync();
 
         // Verify error summary is displayed
         var errorSummary = await page.QuerySelectorAsync(".govuk-error-summary");