forked from invopop/gobl.ubl
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathpayment_parse_test.go
More file actions
244 lines (191 loc) · 8.23 KB
/
payment_parse_test.go
File metadata and controls
244 lines (191 loc) · 8.23 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
package ubl_test
import (
"testing"
"github.com/invopop/gobl/bill"
"github.com/invopop/gobl/catalogues/iso"
"github.com/invopop/gobl/cbc"
"github.com/invopop/gobl/org"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestParsePayment(t *testing.T) {
t.Run("general example", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example2.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
// Check Payee
require.NotNil(t, payment.Payee)
assert.Equal(t, "Ebeneser Scrooge AS", payment.Payee.Name)
require.Len(t, payment.Payee.Identities, 2)
assert.Equal(t, cbc.Code("989823401"), payment.Payee.Identities[0].Code)
// Check Instructions
require.NotNil(t, payment.Instructions)
assert.Equal(t, cbc.Key("credit-transfer"), payment.Instructions.Key)
assert.Equal(t, cbc.Code("0003434323213231"), payment.Instructions.Ref)
require.NotNil(t, payment.Instructions.CreditTransfer)
require.Len(t, payment.Instructions.CreditTransfer, 1)
assert.Equal(t, "NO9386011117947", payment.Instructions.CreditTransfer[0].IBAN)
assert.Equal(t, "DNBANOKK", payment.Instructions.CreditTransfer[0].BIC)
// Check Terms
require.NotNil(t, payment.Terms)
assert.Equal(t, "2 % discount if paid within 2 days\n Penalty percentage 10% from due date", payment.Terms.Notes)
})
}
func TestParsePaymentPayee(t *testing.T) {
t.Run("payee with two identities", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example2.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Payee)
assert.Equal(t, "Ebeneser Scrooge AS", payment.Payee.Name)
require.Len(t, payment.Payee.Identities, 2)
assert.Equal(t, cbc.Code("989823401"), payment.Payee.Identities[0].Code)
assert.Equal(t, "0088", payment.Payee.Identities[1].Ext[iso.ExtKeySchemeID].String())
assert.Equal(t, cbc.Code("2298740918237"), payment.Payee.Identities[1].Code)
})
t.Run("payee with one identity", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example5.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Payee)
assert.Equal(t, "Dagobert Duck", payment.Payee.Name)
// Both PartyLegalEntity.CompanyID and PartyIdentification.ID are parsed as identities
require.Len(t, payment.Payee.Identities, 2)
assert.Equal(t, cbc.Code("DK16356608"), payment.Payee.Identities[0].Code)
assert.Equal(t, org.IdentityScopeLegal, payment.Payee.Identities[0].Scope)
assert.Equal(t, cbc.Code("DK16356608"), payment.Payee.Identities[1].Code)
})
}
func TestParsePaymentInstructions(t *testing.T) {
t.Run("instructions with credit transfer", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example2.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Instructions)
assert.Equal(t, cbc.Key("credit-transfer"), payment.Instructions.Key)
assert.Equal(t, cbc.Code("0003434323213231"), payment.Instructions.Ref)
require.NotNil(t, payment.Instructions.CreditTransfer)
require.Len(t, payment.Instructions.CreditTransfer, 1)
assert.Equal(t, "NO9386011117947", payment.Instructions.CreditTransfer[0].IBAN)
assert.Equal(t, "DNBANOKK", payment.Instructions.CreditTransfer[0].BIC)
})
t.Run("instructions with direct debit", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example5.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Instructions)
assert.Equal(t, cbc.Key("direct-debit"), payment.Instructions.Key)
assert.Equal(t, cbc.Code("Payref1"), payment.Instructions.Ref)
require.NotNil(t, payment.Instructions.DirectDebit)
assert.Equal(t, "123456", payment.Instructions.DirectDebit.Ref)
assert.Equal(t, "DK1212341234123412", payment.Instructions.DirectDebit.Account)
})
t.Run("instructions with notes", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example7.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Instructions)
assert.Equal(t, cbc.Key("credit-transfer"), payment.Instructions.Key)
require.NotNil(t, payment.Instructions.CreditTransfer)
require.Len(t, payment.Instructions.CreditTransfer, 1)
assert.Equal(t, "SEXDABCD", payment.Instructions.CreditTransfer[0].BIC)
assert.Equal(t, "SE1212341234123412", payment.Instructions.CreditTransfer[0].IBAN)
})
t.Run("instructions with only IBAN", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example8.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Instructions)
assert.Equal(t, cbc.Key("credit-transfer"), payment.Instructions.Key)
assert.Equal(t, cbc.Code("1100512149"), payment.Instructions.Ref)
require.NotNil(t, payment.Instructions.CreditTransfer)
require.Len(t, payment.Instructions.CreditTransfer, 1)
assert.Equal(t, "NL28RBOS0420242228", payment.Instructions.CreditTransfer[0].IBAN)
})
}
func TestParsePaymentTerms(t *testing.T) {
t.Run("terms with notes", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example2.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Terms)
assert.Equal(t, "2 % discount if paid within 2 days\n Penalty percentage 10% from due date", payment.Terms.Notes)
})
t.Run("only due date present", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example10.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Terms)
require.Len(t, payment.Terms.DueDates, 1)
assert.NotNil(t, payment.Terms.DueDates[0].Date)
assert.NotNil(t, payment.Terms.DueDates[0].Percent)
assert.Equal(t, "100%", payment.Terms.DueDates[0].Percent.String())
})
}
func TestParsePaymentAdvances(t *testing.T) {
t.Run("totals with prepaid amount", func(t *testing.T) {
e, err := testParseInvoice("en16931/ubl-example2.xml")
require.NoError(t, err)
inv, ok := e.Extract().(*bill.Invoice)
require.True(t, ok)
payment := inv.Payment
require.NotNil(t, payment)
require.NotNil(t, payment.Advances)
assert.Equal(t, "1000.00", payment.Advances[0].Amount.String())
})
}
func TestPaymentRoundTrip(t *testing.T) {
t.Run("account number round trip", func(t *testing.T) {
// Load the test envelope with account number (not IBAN)
env, err := loadTestEnvelope("invoice-account-number.json")
require.NoError(t, err)
originalInv, ok := env.Extract().(*bill.Invoice)
require.True(t, ok)
// Convert to UBL
doc, err := testInvoiceFrom("invoice-account-number.json")
require.NoError(t, err)
// Convert back to GOBL
resultEnv, err := doc.Convert()
require.NoError(t, err)
resultInv, ok := resultEnv.Extract().(*bill.Invoice)
require.True(t, ok)
// Check that the account number is preserved (not moved to IBAN)
require.NotNil(t, resultInv.Payment)
require.NotNil(t, resultInv.Payment.Instructions)
require.NotNil(t, resultInv.Payment.Instructions.CreditTransfer)
require.Len(t, resultInv.Payment.Instructions.CreditTransfer, 1)
// The original has number, not IBAN
assert.Equal(t, "123456789", originalInv.Payment.Instructions.CreditTransfer[0].Number)
assert.Equal(t, "", originalInv.Payment.Instructions.CreditTransfer[0].IBAN)
// After round-trip, the number should still be in the number field, not IBAN
assert.Equal(t, "123456789", resultInv.Payment.Instructions.CreditTransfer[0].Number, "Account number should be preserved in Number field")
assert.Equal(t, "", resultInv.Payment.Instructions.CreditTransfer[0].IBAN, "IBAN should be empty when Number was used")
})
}