Module "com.google.protobuf" conflicts with WildFly's and have different set of deps

[rhusar]

How is this supposed to work? These modules differ significantly and get overriden.

GRPC

<!--

     Copyright The WildFly Authors
     SPDX-License-Identifier: Apache-2.0

-->
<module xmlns="urn:jboss:module:1.9" name="com.google.protobuf">
    <properties>
        <property name="jboss.api" value="private" />
    </properties>

    <resources>
        <artifact name="${com.google.api.grpc:proto-google-common-protos}" />
        <artifact name="${com.google.protobuf:protobuf-java}" />
        <artifact name="${com.google.protobuf:protobuf-java-util}" />
        <artifact name="${io.perfmark:perfmark-api}" />
    </resources>

    <dependencies>
        <module name="com.google.guava" />
        <module name="java.logging" />
        <module name="com.google.code.gson" optional="true"/>
    </dependencies>
</module>

WF

<?xml version="1.0" encoding="UTF-8"?>

<!--
  ~ Copyright The WildFly Authors
  ~ SPDX-License-Identifier: Apache-2.0
  -->

<module xmlns="urn:jboss:module:1.9" name="com.google.protobuf">
    <properties>
        <property name="jboss.api" value="private"/>
    </properties>

    <resources>
        <artifact name="${com.google.api.grpc:proto-google-common-protos}"/>
        <artifact name="${com.google.protobuf:protobuf-java}"/>
        <artifact name="${com.google.protobuf:protobuf-java-util}"/>
    </resources>

    <dependencies>
        <module name="com.google.guava"/>
        <module name="java.logging"/>
    </dependencies>
</module>

[hpehl]

@rhusar I thought each subsystem could use its own dependencies. If that doesn't work, we can make use of WFs deps.

[rhusar]

You can but you would have to use a different module name - otherwise they get overridden. The xml file does but the jars are copied from each. It creates a mess. @jfdenise explained this on a call yesterday, maybe if we need more clarification we can discuss.

[hpehl]

I'm all about streamlining versions across subsystems. @rhusar would you be able to create a PR out of this?

[rhusar]

I'm all about streamlining versions across subsystems. @rhusar would you be able to create a PR out of this?

Well, WF is on ancient versions of these so that's unusable.

The correct way seems to be to create a new module name or use a slot specific to this FP.

With @jamezp work on integrating GRPC right into WF, the versions will have to be aligned anyway.

[rhusar]

Looking at this again we fixed the <artifact name="${io.perfmark:perfmark-api}" /> in this repo, but the <module name="com.google.code.gson" optional="true"/> dependency is missing in WF (needs to be checked whether the version WF uses even uses that dependency, but I think it does).