Skip to content

Commit a26617b

Browse files
authored
Merge pull request #39 from WandiParis/fix-sf4.3-deprecation
fix: symfony 4.3 deprecation - #32
2 parents 6065060 + 7e34448 commit a26617b

File tree

3 files changed

+33
-3
lines changed

3 files changed

+33
-3
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ php:
44
- '7.1'
55

66
before_script:
7-
- composer install --dev -v --prefer-source
7+
- php -d memory_limit=-1 composer install --dev -v --prefer-source
88

99
script:
1010
- bin/phpspec run -fpretty --verbose
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<?php
2+
3+
namespace spec\Welp\MailchimpBundle\DependencyInjection;
4+
5+
use PhpSpec\ObjectBehavior;
6+
7+
class ConfigurationSpec extends ObjectBehavior
8+
{
9+
function it_is_initializable()
10+
{
11+
$this->shouldHaveType('Welp\MailchimpBundle\DependencyInjection\Configuration');
12+
}
13+
14+
function it_is_symfony_configuration()
15+
{
16+
$this->shouldImplement('Symfony\Component\Config\Definition\ConfigurationInterface');
17+
}
18+
19+
function it_gets_config_tree_builder()
20+
{
21+
$this
22+
->getConfigTreeBuilder()
23+
->shouldHaveType('Symfony\Component\Config\Definition\Builder\TreeBuilder');
24+
}
25+
}

src/DependencyInjection/Configuration.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,13 @@ class Configuration implements ConfigurationInterface
1717
*/
1818
public function getConfigTreeBuilder()
1919
{
20-
$treeBuilder = new TreeBuilder();
21-
$rootNode = $treeBuilder->root('welp_mailchimp');
20+
$treeBuilder = new TreeBuilder('welp_mailchimp');
21+
22+
if (method_exists($treeBuilder, 'getRootNode')) {
23+
$rootNode = $treeBuilder->getRootNode();
24+
} else {
25+
$rootNode = $treeBuilder->root('welp_mailchimp');
26+
}
2227

2328
$rootNode
2429
->children()

0 commit comments

Comments
 (0)