Skip to content

Commit ecedc5e

Browse files
fix #98: added bank name (#99)
1 parent 7d129b9 commit ecedc5e

File tree

5 files changed

+11
-17
lines changed

5 files changed

+11
-17
lines changed

.github/pull_request_template.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
**Objective**
2-
Clear and concise description of what's the objective of your PR
2+
<!--Clear and concise description of what's the objective of your PR-->
33

4-
**What's changed**
5-
Which are the changes you've done
4+
**What's changed?**
5+
<!--Which changes you did-->
66

7-
**How to test it**
8-
Impacts of those changes for persons who are already using the application
7+
**How can I test it?**
8+
<!--Describe how to test the changes-->
99

1010
**Additional context**
11-
Any other information relevant to the ones who will evaluate your PR
12-
13-
**Checklist**
14-
[ ] - I did the necessary Unit and Integration tests
15-
[ ] - My PR has an isolated context, I'm changing just one feature
16-
11+
<!--Any other relevant information or about the impact of those changes-->

src/main/kotlin/br/com/webbudget/application/mappers/registration/WalletMapper.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ class WalletMapper {
2727
id = wallet.externalId!!,
2828
name = wallet.name,
2929
type = wallet.type,
30+
bank = wallet.bank,
3031
active = wallet.active
3132
)
3233

src/main/kotlin/br/com/webbudget/application/payloads/registration/WalletPayloads.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ data class WalletListView(
6363
val id: UUID,
6464
val name: String,
6565
val type: Type,
66+
val bank: String? = null,
6667
val active: Boolean = true
6768
)
6869

src/main/resources/db/changelog/2024/10/06-changelog.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,8 @@
189189
<constraints nullable="false"/>
190190
</column>
191191

192-
<column name="id_card" type="bigint">
193-
<constraints nullable="false"/>
194-
</column>
195-
<column name="id_wallet" type="bigint">
196-
<constraints nullable="false"/>
197-
</column>
192+
<column name="id_card" type="bigint"/>
193+
<column name="id_wallet" type="bigint"/>
198194
</createTable>
199195

200196
<addUniqueConstraint columnNames="id"

src/test/kotlin/br/com/webbudget/mappers/registration/WalletMapperUTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ class WalletMapperUTest {
108108
assertThat(it.active).isEqualTo(domainObject.active)
109109
assertThat(it.name).isEqualTo(domainObject.name)
110110
assertThat(it.type).isEqualTo(domainObject.type)
111+
assertThat(it.bank).isEqualTo(domainObject.bank)
111112
})
112113
}
113114

0 commit comments

Comments
 (0)